Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix olm bundle labels #705

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

freeznet
Copy link
Member

@freeznet freeznet commented Oct 25, 2023

Motivation

time="2023-10-23T13:18:08Z" level=info msg="check completed" check=DeployableByOLM err="the bundle cannot be deployed because deployment validation has failed: [{Name:function-mesh.v0.18.0 Errors:[Error: Value : (function-mesh.v0.18.0) csv.Spec.MinKubeVersion has an invalid value: v1.17.0] Warnings:[Warning: Value function-mesh.v0.18.0: this bundle is using APIs which were deprecated and removed in v1.25. More info: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-25. Migrate the API(s) for horizontalpodautoscalers: ([\"ClusterServiceVersion.Spec.InstallStrategy.StrategySpec.ClusterPermissions[0].Rules[1]\"])]} {Name:function-mesh.v0.18.0 Errors:[Error: Value : (function-mesh.v0.18.0) csv.Spec.MinKubeVersion has an invalid value: v1.17.0] Warnings:[Warning: Value : found olm.properties annotation, please define these properties in metadata/properties.yaml instead]}]" result=ERROR

error from openshift certification process

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@freeznet freeznet self-assigned this Oct 25, 2023
@freeznet freeznet requested review from nlu90 and a team as code owners October 25, 2023 02:38
@github-actions
Copy link

@freeznet:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

1 similar comment
@github-actions
Copy link

@freeznet:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added doc-info-missing This pr needs to mark a document option in description and removed doc-info-missing This pr needs to mark a document option in description labels Oct 25, 2023
@github-actions
Copy link

@freeznet:Thanks for providing doc info!

@github-actions github-actions bot added the no-need-doc This pr does not need any document label Oct 25, 2023
@jiangpengcheng jiangpengcheng merged commit 1951d49 into master Oct 25, 2023
16 checks passed
@jiangpengcheng jiangpengcheng deleted the freeznet/fix-bundle-release-csv branch October 25, 2023 03:29
jiangpengcheng pushed a commit that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci no-need-doc This pr does not need any document type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants