-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix permission for cleanupSubscription on OLM installation #704
Conversation
@freeznet:Thanks for your contribution. For this PR, do we need to update docs? |
@freeznet:Thanks for providing doc info! |
@jiangpengcheng please help to verify if 5f67573 is needed. |
It's better to have it Then we need to add such logic to |
Motivation
Failed to cleanupSubscription on OLM installation.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required
(If you need help on updating docs, create a doc issue)
no-need-doc
(Please explain why)
doc
(If this PR contains doc changes)