Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix permission for cleanupSubscription on OLM installation #704

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

freeznet
Copy link
Member

@freeznet freeznet commented Oct 24, 2023

Motivation

W1024 08:06:04.290819       1 reflector.go:424] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:169: failed to list *v1.Pod: pods is forbidden: User "system:serviceaccount:sn-system:function-mesh-controller-manager" cannot list resource "pods" in API group "" at the cluster scope

Failed to cleanupSubscription on OLM installation.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@freeznet freeznet self-assigned this Oct 24, 2023
@freeznet freeznet requested review from nlu90 and a team as code owners October 24, 2023 08:39
@github-actions
Copy link

@freeznet:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Oct 24, 2023
@github-actions github-actions bot removed the doc-info-missing This pr needs to mark a document option in description label Oct 24, 2023
@github-actions
Copy link

@freeznet:Thanks for providing doc info!

@github-actions github-actions bot added the no-need-doc This pr does not need any document label Oct 24, 2023
jiangpengcheng
jiangpengcheng previously approved these changes Oct 24, 2023
@freeznet freeznet changed the title fix permission for cleanup on OLM installation fix permission for cleanupSubscription on OLM installation Oct 24, 2023
@freeznet
Copy link
Member Author

@jiangpengcheng please help to verify if 5f67573 is needed.

@jiangpengcheng
Copy link
Member

@jiangpengcheng please help to verify if 5f67573 is needed.

It's better to have it

Then we need to add such logic to controllers/sink.go#ApplySinkCleanUpJob and cotrollers/source.go#ApplySourceCleanUpJob too

@freeznet freeznet merged commit bee039c into master Oct 24, 2023
12 checks passed
@freeznet freeznet deleted the freeznet/fix-manager-permission branch October 24, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants