Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix e2e pulsar install #651

Merged
merged 2 commits into from
May 25, 2023
Merged

fix e2e pulsar install #651

merged 2 commits into from
May 25, 2023

Conversation

freeznet
Copy link
Member

Motivation

fix

+ helm repo add loki https://grafana.github.io/loki/charts
Error: looks like "https://grafana.github.io/loki/charts" is not a valid chart repository or cannot be reached: failed to fetch https://grafana.github.io/loki/charts/index.yaml : 404 Not Found

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@freeznet freeznet self-assigned this May 24, 2023
@freeznet freeznet requested review from nlu90 and a team as code owners May 24, 2023 03:10
@github-actions
Copy link

@freeznet:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

1 similar comment
@github-actions
Copy link

@freeznet:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label May 24, 2023
@freeznet freeznet merged commit e47603e into master May 25, 2023
@freeznet freeznet deleted the freeznet/fix-e2e-install-failed branch May 25, 2023 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci doc-info-missing This pr needs to mark a document option in description m/2023-05
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants