Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not do clean up resources managed by function-mesh-worker-service #640

Merged
merged 1 commit into from
May 16, 2023

Conversation

jiangpengcheng
Copy link
Member

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

existing resources managed by function-mesh-worker-service also start a clean-up job since they may be created by old function-mesh-worker-service and do not have the compute.functionmesh.io/need-cleanup annotation, we should avoid that

Modifications

Do not clean up for resources managed by function-mesh-worker-service

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@jiangpengcheng jiangpengcheng requested review from nlu90, freeznet and a team as code owners May 11, 2023 04:03
@github-actions github-actions bot added the no-need-doc This pr does not need any document label May 11, 2023
@nlu90 nlu90 added this to the 2023-05 v0.14.0 milestone May 12, 2023
@freeznet freeznet merged commit cbffb06 into streamnative:master May 16, 2023
@freeznet freeznet added type/enhancement Indicates an improvement to an existing feature m/2023-05 labels May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
m/2023-05 no-need-doc This pr does not need any document type/enhancement Indicates an improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants