Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only trigger release action on v* tags and ignore function-mesh-* tags #631

Merged
merged 1 commit into from
May 5, 2023

Conversation

freeznet
Copy link
Member

@freeznet freeznet commented May 4, 2023

Fixes #626

Motivation

The release of helm charts is handled by streamnative-ci, and the release action should not be triggered.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@freeznet freeznet self-assigned this May 4, 2023
@freeznet freeznet requested review from nlu90 and a team as code owners May 4, 2023 10:38
@github-actions
Copy link

github-actions bot commented May 4, 2023

@freeznet:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added doc-info-missing This pr needs to mark a document option in description and removed doc-info-missing This pr needs to mark a document option in description labels May 4, 2023
@github-actions
Copy link

github-actions bot commented May 4, 2023

@freeznet:Thanks for providing doc info!

@github-actions github-actions bot added the no-need-doc This pr does not need any document label May 4, 2023
@freeznet freeznet merged commit 5dfa387 into master May 5, 2023
@freeznet freeznet deleted the freeznet/fix-release-tags branch May 5, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci m/2023-05 no-need-doc This pr does not need any document type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Released docker image tag has typo and wrong "pushed by"
2 participants