Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pulsarctl to runner #630

Merged
merged 8 commits into from
May 10, 2023

Conversation

jiangpengcheng
Copy link
Member

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #629

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@jiangpengcheng jiangpengcheng requested review from nlu90, freeznet and a team as code owners May 4, 2023 09:13
@github-actions github-actions bot added the no-need-doc This pr does not need any document label May 4, 2023
Copy link
Member

@freeznet freeznet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance to use only one latest version of pulsarctl instead of the different versions for different pulsar branches?

@freeznet freeznet added type/enhancement Indicates an improvement to an existing feature component/runner-images m/2023-05 labels May 4, 2023
nlu90
nlu90 previously approved these changes May 5, 2023
@jiangpengcheng
Copy link
Member Author

Any chance to use only one latest version of pulsarctl instead of the different versions for different pulsar branches?

I wonder whether there are compatibility issues if we use one version of pulsarctl for all pulsar branches, @zymap do you have any advice?

@freeznet
Copy link
Member

freeznet commented May 6, 2023

Any chance to use only one latest version of pulsarctl instead of the different versions for different pulsar branches?

I wonder whether there are compatibility issues if we use one version of pulsarctl for all pulsar branches, @zymap do you have any advice?

The pulsarctl and pulsar-admin-go should have backward compatibility. For function-mesh, it only uses resource cleanup (like topics management and subscription management), package download etc., which should not have differences across the branches.

On the other hand, can we have two types of runner images published to docker hub, such as:

  1. runner image with pulsar-admin
  2. runner image with pulsarctl

@zymap
Copy link
Member

zymap commented May 6, 2023

it only uses resource cleanup (like topics management and subscription management), package download etc., which should not have differences across the branches.

Yes. You could use it for all pulsar versions. The different versions are similar. IIRC, the only difference may be the fields in some stats commands.

@jiangpengcheng
Copy link
Member Author

On the other hand, can we have two types of runner images published to docker hub, such as:

  1. runner image with pulsar-admin
  2. runner image with pulsarctl

it sounds good, we can even reduce the image size by using the runner image with pulsarctl, and finally deprecate the runner-image with pulsar-admin, I will try it

@nlu90 nlu90 merged commit ab8215f into streamnative:master May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/runner-images m/2023-05 no-need-doc This pr does not need any document type/enhancement Indicates an improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants