-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pulsarctl to runner #630
Add pulsarctl to runner #630
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance to use only one latest version of pulsarctl instead of the different versions for different pulsar branches?
I wonder whether there are compatibility issues if we use one version of pulsarctl for all pulsar branches, @zymap do you have any advice? |
The On the other hand, can we have two types of runner images published to docker hub, such as:
|
Yes. You could use it for all pulsar versions. The different versions are similar. IIRC, the only difference may be the fields in some stats commands. |
it sounds good, we can even reduce the image size by using the runner image with pulsarctl, and finally deprecate the runner-image with pulsar-admin, I will try it |
bad294f
to
10ae3c6
Compare
(If this PR fixes a github issue, please add
Fixes #<xyz>
.)Fixes #
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>
to link to the master issue.)Master Issue: #629
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required
(If you need help on updating docs, create a doc issue)
no-need-doc
(Please explain why)
doc
(If this PR contains doc changes)