Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python runner image with pulsar newer than 3.0.0 #625

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

jiangpengcheng
Copy link
Member

@jiangpengcheng jiangpengcheng commented Apr 19, 2023

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #565

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@jiangpengcheng jiangpengcheng requested review from nlu90, freeznet and a team as code owners April 19, 2023 09:01
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Apr 19, 2023
freeznet
freeznet previously approved these changes Apr 19, 2023
Copy link
Member

@yaalsn yaalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@freeznet freeznet merged commit bc3beff into streamnative:master Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python runner for pulsar master branch
3 participants