Replace ConnectorCatalog.ConfigFieldDefinitions with SourceConfigFieldDefinitions and SinkConfigFieldDefinitions #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dDefinitions and SinkConfigFieldDefinitions
freeznet
approved these changes
Mar 13, 2023
nlu90
pushed a commit
that referenced
this pull request
Aug 9, 2023
* Revert "Replace ConnectorCatalog.ConfigFieldDefinitions with SourceConfigFieldDefinitions and SinkConfigFieldDefinitions (#610)" This reverts commit 77d77e9. # Conflicts: # charts/function-mesh-operator/charts/admission-webhook/templates/crd-compute.functionmesh.io-connectorcatalogs.yaml * Revert "Manage builtin-connectors through ConnectorCatalog CRD (#585)" This reverts commit 51e480f. # Conflicts: # go.mod # main.go # pkg/webhook/connectorcatalog_webhook.go * revert changes * revert main.go * revert common.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #609
Motivation
The config field definitions need to be separate for connectors that define both source and sink interfaces.
Modifications
Separated the configFieldDefinitions into parameters for source and sink separately.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)