Fix liveness probe #604
Merged
Fix liveness probe #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpiperatgod
previously approved these changes
Mar 10, 2023
nlu90
approved these changes
Mar 10, 2023
jiangpengcheng
added a commit
to jiangpengcheng/function-mesh
that referenced
this pull request
Mar 13, 2023
* Use metrics port for liveness probe * Update * Disable builtin health check * Generate chart * Fix style * Use root path
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #602
Master Issue: #
Motivation
The PVC using local storage cannot be mounted to pods on different node, so it's not safe to achieve liveness probe with PVC
Modifications
This PR will use the metrics port to do the liveness probe, and disable instance's builtin health check since there is no grpc requests will be made
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)