Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use SubPath when jar(py|go)Location is /pulsar/xxx.suffix #579

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

jiangpengcheng
Copy link
Member

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #577

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • *Added integration tests for pyLocation is /pulsar/download/pulsar_functions/exclamation.zip

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@github-actions github-actions bot added the no-need-doc This pr does not need any document label Feb 23, 2023
@freeznet freeznet merged commit 3b5ff85 into streamnative:master Feb 24, 2023
jiangpengcheng added a commit to jiangpengcheng/function-mesh that referenced this pull request Mar 3, 2023
…mnative#579)

* Only use SubPath when jar(py|go)Location is /pulsar/xxx.suffix

* Fix codacy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/0.11 m/2023-03 no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the fsGroup doesn't work if volume mount use an existing file/dir as subpath
2 participants