Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove image unused deps #576

Merged
merged 3 commits into from
Feb 22, 2023
Merged

remove image unused deps #576

merged 3 commits into from
Feb 22, 2023

Conversation

freeznet
Copy link
Member

@freeznet freeznet commented Feb 22, 2023

Master Issue: #575

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@freeznet freeznet requested a review from nlu90 as a code owner February 22, 2023 09:10
@freeznet freeznet self-assigned this Feb 22, 2023
@freeznet freeznet requested a review from a team as a code owner February 22, 2023 09:10
@freeznet freeznet added type/enhancement Indicates an improvement to an existing feature component/runner-images labels Feb 22, 2023
@github-actions
Copy link

@freeznet:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added doc-info-missing This pr needs to mark a document option in description and removed doc-info-missing This pr needs to mark a document option in description labels Feb 22, 2023
@github-actions
Copy link

@freeznet:Thanks for providing doc info!

@github-actions github-actions bot added the no-need-doc This pr does not need any document label Feb 22, 2023
@nlu90 nlu90 merged commit 6675048 into master Feb 22, 2023
@nlu90 nlu90 deleted the freeznet/remove-image-unused-deps branch February 22, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/runner-images m/2023-03 no-need-doc This pr does not need any document type/enhancement Indicates an improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants