Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FM v0.14.0]--Update docs for cleaning up subcription configs #260

Merged
merged 2 commits into from
May 26, 2023

Conversation

Huanli-Meng
Copy link
Contributor

Motivation

Function Mesh v0.14.0 fixed the bug that CleanupSubscription option doesn't work, and batch source doesn't cleanup intermediate topic either (code PR #622)

Modification

Update function/Sink/source CRD configurations

@Huanli-Meng Huanli-Meng self-assigned this May 24, 2023
@Huanli-Meng Huanli-Meng requested review from tuteng and a team as code owners May 24, 2023 07:13
@netlify
Copy link

netlify bot commented May 24, 2023

Deploy Preview for function-mesh ready!

Name Link
🔨 Latest commit 5a99b09
🔍 Latest deploy log https://app.netlify.com/sites/function-mesh/deploys/646f61489251510007ed6ffc
😎 Deploy Preview https://deploy-preview-260--function-mesh.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@@ -121,6 +122,23 @@ Function Mesh provides Pulsar cluster configurations in the Function, Source, an
</ul>
</td>
</tr>
<tr>
<td><code>cleanupAuthConfig</code></td>
<td>The authentication configurations for removing subscriptions and intermediate topics. You can configure generic authentication or <a href="https://oauth.net/">OAuth2 authentication</a> through this field. <p><b>Generic authentication</b></p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add if not provided, the authConfig will be used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. PTAL.

@Huanli-Meng Huanli-Meng merged commit 5ecebba into main May 26, 2023
@Huanli-Meng Huanli-Meng deleted the clean-up-sub branch May 26, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants