Switch to helix API #852
Merged
Switch to helix API #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bastimeyer
force-pushed
the
helix
branch
4 times, most recently
from
ef8f337
to
3514a08
Compare
4 tasks
bastimeyer
force-pushed
the
helix
branch
4 times, most recently
from
ab4b9d0
to
4b4fed1
Compare
bastimeyer
force-pushed
the
helix
branch
8 times, most recently
from
e28a988
to
811733c
Compare
- adapterRequestFactory: for easier API response stubbing - assertRelationships: for checking model relationship data Also - deeply clone mocked adapter response the TwitchSerializer will normalize the response object in-place
TwitchAdapter: - remove "Accept" header - change OAuth token to Bearer token - remove urlFragments and AuthService injection - refactor findId logic - use same param name for findRecord and findMany - fall back to serializer's primaryKey if findIdParam is null - switch to helix API's multi-ID serialization style - limit number of ID requests via findIdMax TwitchSerializer: - change default primaryKey from "_id" to "id" - normalize "data" payload property - treat everything non-"data" as metadata
- TwitchChannelFollowed - TwitchRoot - TwitchSearchStream - TwitchStreamFeatured - TwitchStreamSummary
- remove FeaturedRoute and update application router - change default homepage to StreamsRoute - add update logic for local storage - remove/change links, update MainMenuComponent and fix translations - remove FeaturedRoute hotkeys and update hotkeys for other routes
- remove filtering logic - simplify willFetchContent - simplify hasFetchedAll - split calcFetchSize into calcFetchSize + setFetchSize - remove most Ember.get calls - rewrite tests, split up into CSS and Mixin tests
- add InfiniteScrollPaginationMixin based on InfiniteScrollCursorMixin - remove InfiniteScrollOffsetMixin and InfiniteScrollCursorMixin - replace imports in various routes with InfiniteScrollPaginationMixin - fix InfiniteScrollCommonMixin and wait for mapped promises to resolve Next: - fix each route's infinite-scroll and pagination parameters - fix each route's model hooks and related stuff - test pagination mixin via route tests
- reference games by ID instead of names in GamesGameRouter This will break custom game homepages, but there's nothing that can be done here to automatically fix this. Users will have to reset their custom homepage. - inherit from UserIndexRoute - fix infinite-scroll / pagination parameters - reformat templates
- inherit from UserIndexRoute - fix infinite-scroll / pagination parameters - reformat template
- fix infinite-scroll / pagination parameters - remove custom model hook for the old kraken API bug and remove tests - reformat template
- fix infinite-scroll / pagination parameters - remove controller and query parameters for sorting (unsupported now) - reformat template
- update route parameter name in router - inherit from UserIndexRoute - fix/rewrite model hooks - fix infinite-scroll / pagination parameters - reformat templates
- update route parameter name in router - inherit from UserIndexRoute - fix/rewrite model hooks - reformat templates
Querying random streams is not possible anymore on the helix API, as there's no available offset query parameter. At most 100 streams can be queried in one request and then new requests can be made with the provided pagination cursor query parameter. This means that finding random streams becomes unnecessarily expensive at a certain point.
- remove "streams" filter - remove old and unused label code - add localStorage update logic and add tests
- update addRecord logic and add tests - reformat template
- inherit from UserIndexRoute - fix/rewrite model hooks - reformat template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #849
Checklist
Rate limit handling(not important right now, can be done later)TwitchStreamTag(will be implemented later)FilterLanguagesMixin(will (re-)implement multi-language filtering later - once again supported on helix)Known issues