SCRIPT: Updated script for multiple goroutines#5
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the geth development script to enable configurable concurrency for block flushing by introducing a new environment variable.
- Introduces validation for the CONCURRENT_BLOCK_FLUSHING environment variable.
- Updates the JSON configuration for vmtrace to include the concurrentBlockFlushing parameter.
Comments suppressed due to low confidence (1)
scripts/wrapped_geth_dev.sh:46
- Ensure that if forced_backward_compatibility is non-empty, it includes a leading comma so that the resulting JSON configuration is valid.
json_config="{"applyBackwardCompatibility":${backward_compatibility},"concurrentBlockFlushing":${concurrent_block_flushing}${forced_backward_compatibility}}"
maoueh
requested changes
May 15, 2025
Contributor
maoueh
left a comment
maoueh
left a comment
There was a problem hiding this comment.
Let's wait on other PR review to decide on a final name here.
Comment on lines
+24
to
+25
| # CONCURRENT_BLOCK_FLUSHING=true ./scripts/run_firehose_geth_dev.sh 3.0 prague | ||
| concurrent_block_flushing="${CONCURRENT_BLOCK_FLUSHING:-0}" |
Contributor
There was a problem hiding this comment.
Now with a count, the variable is really not aligned anymore, we will need to find a better name as there is actually no concurrent flushing.
The value controls are many worker pick from the queue correct?
Contributor
Author
There was a problem hiding this comment.
Correct. 0 means 0 workers, so no concurrency whereas 100 would mean 100 concurrent workers
maoueh
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Introduced
Configuration path to allow multiple goroutines concurrency
Notes