feat(useBeforeUnload): allow passing a dirty function (#842) #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bebbi
force-pushed
the
feat/before-unload-callback
branch
from
d0aff00 to
c4a14a4
Compare
|
@streamich stumbled into another review, made an aesthetic fix and did a history-rewriting commit (c4a14) assuming you haven't pulled it yet. |
|
🎉 This PR is included in version 13.25.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@streamich doesn't work with react router - correct? If you need to maintain routing to another page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow passing a function as dirty flag to
useBeforeUnloadhook.Link documentation of an example how to use this with fast-changing dirty functions.
Closes #842
Type of change
Checklist
yarn test)yarn lint). Fix it withyarn lint:fixin case of failure.yarn lint:types).