Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set value on adding setter in createGlobalState #2564

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

extempl
Copy link

@extempl extempl commented Jun 19, 2024

Description

I found the issue with alike code I added as a test where while we used single global state we get different values in different components setting state as a ref.
So there is a tiny time period when we already initialised both states with default state values (undefined), then added one setter, call global setter (with all setters added) and only then added another setter, forever remembering the initial state for that particular instance of global state.
So I added additional state update to the place we adding the setter to update it with actual global state.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

  • Read the Contributing Guide
  • Perform a code self-review
  • Comment the code, particularly in hard-to-understand areas
  • Add documentation
  • Add hook's story at Storybook
  • Cover changes with tests
  • Ensure the test suite passes (yarn test)
  • Provide 100% tests coverage
  • Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
  • Make sure types are fine (yarn lint:types).

@extempl extempl changed the title Set value on adding setter Set value on adding setter in createGlobalState Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant