Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply settings back to created source after requesting properties from FE #1385

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

summeroff
Copy link
Contributor

@summeroff summeroff commented Dec 23, 2023

Description

Apply settings back to created source when properties get requested.

Motivation and Context

Current implementation of utility::ProcessProperties does not change updateSource flag.
It leads to missed settings update.

Some values for properties gets populated only inside obs_source_properties. Like the list of displays. And without update source will use non working default values.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@summeroff summeroff changed the title apply settings back to obs after requesting them for FE Apply settings back to created source after requesting properties from FE Jan 2, 2024
@summeroff summeroff merged commit 42e1ffb into staging Jan 3, 2024
8 of 12 checks passed
@rosendolu
Copy link

rosendolu commented May 6, 2024

Hi @avoitenko-logitech @summeroff is there a way to update source settings after created? I try to update settings fileds but not work. sceneItem position works well
img_v3_02ak_d09dd497-c628-42c5-a09a-10acd52415dg

Even if called the update methods
sceneItem.source.update(sceneItem.source.settings)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants