Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope 'push' GitHub Actions workflow trigger to 'main' branch #78

Merged
merged 1 commit into from
Oct 15, 2022

Conversation

lopopolo
Copy link
Collaborator

The previous configuration causes all jobs to run twice on every PR. We should consider protecting the main branch and requiring PRs if that is not already the case.

The previous configuration causes all jobs to run twice on every PR. We should
consider protecting the main branch and requiring PRs if that is not already
the case.
@lopopolo lopopolo added the bug Something isn't working label Oct 14, 2022
@astraw astraw merged commit f00bfb3 into main Oct 15, 2022
@astraw
Copy link
Member

astraw commented Oct 15, 2022

The CI failures on Android look like a nightly rust problem as they are not happening on stable nor on nightly on other platforms. The Mac issue is described at #72 and is also unrelated.

I don't understand as much about the github CI admin config as I could, but I'll take your word for it that this is a good thing.

In a similar vein, I just did as you suggested and created a new rule that a PR is required before merging to main and a require also minimum of 1 approval.

Relatedly, I made you and @Kijewski both admins on this repo, so we now mostly have a bus factor of 3. Also at the moment I think only @Kijewski and I can publish releases to crates.io. Happy to also add you there if you like, too.

@astraw astraw deleted the lopopolo/github-actions-triggers branch October 15, 2022 09:03
@lopopolo
Copy link
Collaborator Author

Thanks for making those changes @astraw. I think I'd be more comfortable without publisher privileges for now if that's ok. If there's a need to add another publisher later, we can revisit that though.

@lopopolo
Copy link
Collaborator Author

@astraw I believe rust-lang/cc-rs#728 will fix the issues with android on nightly since the latest nightly made changes to which Android NDK is used: https://rust-lang.zulipchat.com/#narrow/stream/219381-t-libs/topic/1.2E65.20and.20the.20Android.20NDK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants