set crates versions for v1.0.0 release#785
Merged
plebhash merged 7 commits intostratum-mining:mainfrom Mar 19, 2024
Merged
Conversation
Merged
Contributor
|
| Report | Thu, March 14, 2024 at 15:56:10 UTC |
| Project | Stratum v2 (SRI) |
| Branch | crates-v1.0.0 |
| Testbed | sv1 |
| Benchmark | Estimated Cycles | Estimated Cycles Results estimated cycles | (Δ%) | Estimated Cycles Upper Boundary estimated cycles | (%) | Instructions | Instructions Results instructions | (Δ%) | Instructions Upper Boundary instructions | (%) | L1 Accesses | L1 Accesses Results accesses | (Δ%) | L1 Accesses Upper Boundary accesses | (%) | L2 Accesses | L2 Accesses Results accesses | (Δ%) | L2 Accesses Upper Boundary accesses | (%) | RAM Accesses | RAM Accesses Results accesses | (Δ%) | RAM Accesses Upper Boundary accesses | (%) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| get_authorize | ✅ (view plot) | 8440.000 (-0.10%) | 8491.832 (99.39%) | ✅ (view plot) | 3746.000 (-0.06%) | 3768.078 (99.41%) | ✅ (view plot) | 5250.000 (-0.08%) | 5288.693 (99.27%) | ✅ (view plot) | 8.000 (+9.29%) | 9.595 (83.38%) | ✅ (view plot) | 90.000 (-0.22%) | 91.264 (98.62%) |
| get_submit | ✅ (view plot) | 95537.000 (-0.01%) | 95600.914 (99.93%) | ✅ (view plot) | 59439.000 (-0.02%) | 59507.603 (99.88%) | ✅ (view plot) | 85352.000 (-0.02%) | 85474.670 (99.86%) | ✅ (view plot) | 56.000 (+2.04%) | 60.031 (93.29%) | ✅ (view plot) | 283.000 (+0.03%) | 284.950 (99.32%) |
| get_subscribe | ✅ (view plot) | 8003.000 (+0.08%) | 8061.202 (99.28%) | ✅ (view plot) | 2841.000 (+0.00%) | 2848.872 (99.72%) | ✅ (view plot) | 3968.000 (-0.02%) | 3983.043 (99.62%) | ✅ (view plot) | 16.000 (+2.30%) | 19.470 (82.18%) | ✅ (view plot) | 113.000 (+0.14%) | 114.542 (98.65%) |
| serialize_authorize | ✅ (view plot) | 12159.000 (-0.28%) | 12323.899 (98.66%) | ✅ (view plot) | 5317.000 (-0.04%) | 5339.078 (99.59%) | ✅ (view plot) | 7414.000 (-0.05%) | 7449.274 (99.53%) | ✅ (view plot) | 11.000 (+3.00%) | 12.871 (85.47%) | ✅ (view plot) | 134.000 (-0.68%) | 137.924 (97.15%) |
| serialize_deserialize_authorize | ✅ (view plot) | 24476.000 (-0.06%) | 24567.776 (99.63%) | ✅ (view plot) | 9898.000 (-0.05%) | 9941.160 (99.57%) | ✅ (view plot) | 13956.000 (-0.07%) | 14034.685 (99.44%) | ✅ (view plot) | 39.000 (+3.50%) | 42.223 (92.37%) | ✅ (view plot) | 295.000 (-0.09%) | 296.964 (99.34%) |
| serialize_deserialize_handle_authorize | ✅ (view plot) | 30187.000 (+0.04%) | 30249.926 (99.79%) | ✅ (view plot) | 12101.000 (-0.02%) | 12123.078 (99.82%) | ✅ (view plot) | 17122.000 (-0.02%) | 17162.588 (99.76%) | ✅ (view plot) | 58.000 (-0.62%) | 62.610 (92.64%) | ✅ (view plot) | 365.000 (+0.14%) | 366.946 (99.47%) |
| serialize_deserialize_handle_submit | ✅ (view plot) | 126430.000 (+0.01%) | 126490.688 (99.95%) | ✅ (view plot) | 73224.000 (-0.01%) | 73292.530 (99.91%) | ✅ (view plot) | 104940.000 (-0.02%) | 105066.761 (99.88%) | ✅ (view plot) | 126.000 (+3.89%) | 133.664 (94.27%) | ✅ (view plot) | 596.000 (+0.03%) | 598.423 (99.60%) |
| serialize_deserialize_handle_subscribe | ✅ (view plot) | 27519.000 (+0.12%) | 27558.185 (99.86%) | ✅ (view plot) | 9643.000 (+0.00%) | 9650.872 (99.92%) | ✅ (view plot) | 13634.000 (-0.02%) | 13654.098 (99.85%) | ✅ (view plot) | 68.000 (+2.72%) | 73.257 (92.82%) | ✅ (view plot) | 387.000 (+0.21%) | 388.498 (99.61%) |
| serialize_deserialize_submit | ✅ (view plot) | 115019.000 (-0.03%) | 115198.851 (99.84%) | ✅ (view plot) | 68001.000 (-0.03%) | 68138.061 (99.80%) | ✅ (view plot) | 97554.000 (-0.04%) | 97791.880 (99.76%) | ✅ (view plot) | 70.000 (+1.69%) | 73.585 (95.13%) | ✅ (view plot) | 489.000 (-0.03%) | 491.167 (99.56%) |
| serialize_deserialize_subscribe | ✅ (view plot) | 22904.000 (+0.01%) | 22941.052 (99.84%) | ✅ (view plot) | 8195.000 (-0.01%) | 8207.748 (99.84%) | ✅ (view plot) | 11539.000 (-0.02%) | 11564.262 (99.78%) | ✅ (view plot) | 40.000 (+0.70%) | 45.266 (88.37%) | ✅ (view plot) | 319.000 (+0.03%) | 320.136 (99.65%) |
| serialize_submit | ✅ (view plot) | 99820.000 (-0.03%) | 99997.445 (99.82%) | ✅ (view plot) | 61483.000 (-0.01%) | 61551.603 (99.89%) | ✅ (view plot) | 88200.000 (-0.02%) | 88317.835 (99.87%) | ✅ (view plot) | 56.000 (+1.16%) | 59.140 (94.69%) | ✅ (view plot) | 324.000 (-0.20%) | 326.844 (99.13%) |
| serialize_subscribe | ✅ (view plot) | 11298.000 (-0.17%) | 11433.049 (98.82%) | ✅ (view plot) | 4188.000 (+0.00%) | 4195.872 (99.81%) | ✅ (view plot) | 5828.000 (+0.01%) | 5839.247 (99.81%) | ✅ (view plot) | 16.000 (0.00%) | 19.132 (83.63%) | ✅ (view plot) | 154.000 (-0.36%) | 157.697 (97.66%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
Contributor
|
| Report | Thu, March 14, 2024 at 15:56:09 UTC |
| Project | Stratum v2 (SRI) |
| Branch | 785/merge |
| Testbed | sv1 |
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|
| client-submit-serialize | ✅ (view plot) | 6890.300 (-0.02%) | 7199.622 (95.70%) |
| client-submit-serialize-deserialize | ✅ (view plot) | 7923.100 (+1.59%) | 8113.962 (97.65%) |
| client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle | ✅ (view plot) | 8416.500 (+0.59%) | 8677.409 (96.99%) |
| client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle | ✅ (view plot) | 887.000 (-2.02%) | 987.315 (89.84%) |
| client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize | ✅ (view plot) | 697.500 (+0.06%) | 714.622 (97.60%) |
| client-sv1-authorize-serialize/client-sv1-authorize-serialize | ✅ (view plot) | 248.570 (-0.03%) | 256.952 (96.74%) |
| client-sv1-get-authorize/client-sv1-get-authorize | ✅ (view plot) | 156.190 (-0.49%) | 158.892 (98.30%) |
| client-sv1-get-submit | ✅ (view plot) | 6706.700 (+0.57%) | 6966.841 (96.27%) |
| client-sv1-get-subscribe/client-sv1-get-subscribe | ✅ (view plot) | 290.450 (+3.35%) | 294.709 (98.55%) |
| client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle | ✅ (view plot) | 748.910 (-0.18%) | 787.547 (95.09%) |
| client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize | ✅ (view plot) | 612.220 (-0.32%) | 635.440 (96.35%) |
| client-sv1-subscribe-serialize/client-sv1-subscribe-serialize | ✅ (view plot) | 218.580 (+2.52%) | 238.109 (91.80%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
Contributor
|
| Report | Thu, March 14, 2024 at 15:56:22 UTC |
| Project | Stratum v2 (SRI) |
| Branch | crates-v1.0.0 |
| Testbed | sv2 |
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|
| client_sv2_handle_message_common | ✅ (view plot) | 44.123 (-0.49%) | 44.954 (98.15%) |
| client_sv2_handle_message_mining | ✅ (view plot) | 72.391 (+1.99%) | 80.426 (90.01%) |
| client_sv2_mining_message_submit_standard | ✅ (view plot) | 14.665 (+0.02%) | 14.692 (99.82%) |
| client_sv2_mining_message_submit_standard_serialize | ✅ (view plot) | 271.290 (+1.48%) | 281.642 (96.32%) |
| client_sv2_mining_message_submit_standard_serialize_deserialize | ✅ (view plot) | 578.470 (-0.89%) | 603.908 (95.79%) |
| client_sv2_open_channel | ✅ (view plot) | 161.480 (-1.94%) | 169.582 (95.22%) |
| client_sv2_open_channel_serialize | ✅ (view plot) | 286.120 (+0.27%) | 297.521 (96.17%) |
| client_sv2_open_channel_serialize_deserialize | ✅ (view plot) | 384.970 (+1.78%) | 414.195 (92.94%) |
| client_sv2_setup_connection | ✅ (view plot) | 162.960 (-0.12%) | 170.763 (95.43%) |
| client_sv2_setup_connection_serialize | ✅ (view plot) | 506.780 (+6.00%) | 510.856 (99.20%) |
| client_sv2_setup_connection_serialize_deserialize | ✅ (view plot) | 1014.400 (+3.90%) | 1053.580 (96.28%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
Contributor
|
| Report | Thu, March 14, 2024 at 15:56:10 UTC |
| Project | Stratum v2 (SRI) |
| Branch | crates-v1.0.0 |
| Testbed | sv2 |
| Benchmark | Estimated Cycles | Estimated Cycles Results estimated cycles | (Δ%) | Estimated Cycles Upper Boundary estimated cycles | (%) | Instructions | Instructions Results instructions | (Δ%) | Instructions Upper Boundary instructions | (%) | L1 Accesses | L1 Accesses Results accesses | (Δ%) | L1 Accesses Upper Boundary accesses | (%) | L2 Accesses | L2 Accesses Results accesses | (Δ%) | L2 Accesses Upper Boundary accesses | (%) | RAM Accesses | RAM Accesses Results accesses | (Δ%) | RAM Accesses Upper Boundary accesses | (%) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| client_sv2_handle_message_common | ✅ (view plot) | 2018.000 (-0.74%) | 2106.415 (95.80%) | ✅ (view plot) | 461.000 (-1.34%) | 479.787 (96.08%) | ✅ (view plot) | 718.000 (-1.34%) | 748.040 (95.98%) | ✅ (view plot) | 8.000 (+12.36%) | 10.718 (74.64%) | ✅ (view plot) | 36.000 (-0.77%) | 38.365 (93.84%) |
| client_sv2_handle_message_mining | ✅ (view plot) | 8134.000 (+0.12%) | 8193.853 (99.27%) | ✅ (view plot) | 2133.000 (+0.84%) | 2171.746 (98.22%) | ✅ (view plot) | 3159.000 (+1.01%) | 3223.145 (98.01%) | ✅ (view plot) | 36.000 (-7.41%) | 44.970 (80.05%) | ✅ (view plot) | 137.000 (-0.15%) | 139.142 (98.46%) |
| client_sv2_mining_message_submit_standard | ✅ (view plot) | 6246.000 (-0.70%) | 6416.789 (97.34%) | ✅ (view plot) | 1742.000 (-0.40%) | 1760.092 (98.97%) | ✅ (view plot) | 2541.000 (-0.37%) | 2568.999 (98.91%) | ✅ (view plot) | 20.000 (+2.04%) | 24.113 (82.94%) | ✅ (view plot) | 103.000 (-1.00%) | 107.800 (95.55%) |
| client_sv2_mining_message_submit_standard_serialize | ✅ (view plot) | 14685.000 (+0.15%) | 14812.977 (99.14%) | ✅ (view plot) | 4686.000 (-0.15%) | 4704.092 (99.62%) | ✅ (view plot) | 6745.000 (-0.16%) | 6774.016 (99.57%) | ✅ (view plot) | 48.000 (-0.66%) | 52.946 (90.66%) | ✅ (view plot) | 220.000 (+0.46%) | 223.211 (98.56%) |
| client_sv2_mining_message_submit_standard_serialize_deserialize | ✅ (view plot) | 27274.000 (-0.05%) | 27450.816 (99.36%) | ✅ (view plot) | 10529.000 (-0.07%) | 10547.092 (99.83%) | ✅ (view plot) | 15324.000 (-0.07%) | 15352.869 (99.81%) | ✅ (view plot) | 87.000 (+0.74%) | 92.052 (94.51%) | ✅ (view plot) | 329.000 (-0.05%) | 334.023 (98.50%) |
| client_sv2_open_channel | ✅ (view plot) | 4405.000 (-0.98%) | 4565.293 (96.49%) | ✅ (view plot) | 1453.000 (-0.43%) | 1471.787 (98.72%) | ✅ (view plot) | 2145.000 (-0.39%) | 2170.565 (98.82%) | ✅ (view plot) | 11.000 (-0.36%) | 13.952 (78.84%) | ✅ (view plot) | 63.000 (-1.56%) | 67.132 (93.85%) |
| client_sv2_open_channel_serialize | ✅ (view plot) | 14118.000 (+0.06%) | 14249.361 (99.08%) | ✅ (view plot) | 5056.000 (-0.12%) | 5074.787 (99.63%) | ✅ (view plot) | 7308.000 (-0.15%) | 7338.441 (99.59%) | ✅ (view plot) | 39.000 (+2.74%) | 41.770 (93.37%) | ✅ (view plot) | 189.000 (+0.21%) | 192.581 (98.14%) |
| client_sv2_open_channel_serialize_deserialize | ✅ (view plot) | 22356.000 (-0.29%) | 22637.807 (98.76%) | ✅ (view plot) | 7971.000 (-0.08%) | 7989.787 (99.76%) | ✅ (view plot) | 11606.000 (-0.06%) | 11635.584 (99.75%) | ✅ (view plot) | 71.000 (-1.55%) | 78.179 (90.82%) | ✅ (view plot) | 297.000 (-0.51%) | 304.573 (97.51%) |
| client_sv2_setup_connection | ✅ (view plot) | 4699.000 (-0.30%) | 4782.659 (98.25%) | ✅ (view plot) | 1494.000 (-0.42%) | 1512.787 (98.76%) | ✅ (view plot) | 2264.000 (-0.40%) | 2293.472 (98.71%) | ✅ (view plot) | 11.000 (-1.43%) | 14.020 (78.46%) | ✅ (view plot) | 68.000 (-0.18%) | 69.995 (97.15%) |
| client_sv2_setup_connection_serialize | ✅ (view plot) | 16224.000 (+0.24%) | 16345.548 (99.26%) | ✅ (view plot) | 5955.000 (-0.10%) | 5973.787 (99.69%) | ✅ (view plot) | 8644.000 (-0.14%) | 8675.700 (99.63%) | ✅ (view plot) | 46.000 (+2.59%) | 48.560 (94.73%) | ✅ (view plot) | 210.000 (+0.61%) | 213.171 (98.51%) |
| client_sv2_setup_connection_serialize_deserialize | ✅ (view plot) | 35468.000 (+0.10%) | 35542.252 (99.79%) | ✅ (view plot) | 14798.000 (-0.04%) | 14816.787 (99.87%) | ✅ (view plot) | 21733.000 (-0.07%) | 21769.776 (99.83%) | ✅ (view plot) | 101.000 (+4.64%) | 109.199 (92.49%) | ✅ (view plot) | 378.000 (+0.21%) | 380.015 (99.47%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
plebhash
force-pushed
the
crates-v1.0.0
branch
2 times, most recently
from
3823cbb to
4036e2a
Compare
GitGab19
reviewed
Mar 8, 2024
GitGab19
reviewed
Mar 8, 2024
plebhash
changed the title
plebhash
changed the title
plebhash
force-pushed
the
crates-v1.0.0
branch
2 times, most recently
from
9e43162 to
f0c574a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
GitGab19
approved these changes
Mar 14, 2024
Fi3
approved these changes
Mar 19, 2024
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in the past, we didn't follow
SemVer 2.0.0while versioning the SRI cratesas we prepare for the
v1.0.0release, it is a good idea to set all crates into the same baseline, under the assumption that going forward, all SRI crates versioning will followSemVer 2.0.0, as discussed on #766the only exceptions are:
noise-sv2crate, which is starting fromv1.1.0rolescrates, which are still somewhat immature, so they remain atv0.1.0