refactor Release Bin action#767
Merged
GitGab19 merged 2 commits intostratum-mining:mainfrom Mar 21, 2024
Merged
Conversation
Contributor
|
| Report | Thu, March 21, 2024 at 20:36:32 UTC |
| Project | Stratum v2 (SRI) |
| Branch | release-bin |
| Testbed | sv2 |
| Benchmark | Estimated Cycles | Estimated Cycles Results estimated cycles | (Δ%) | Estimated Cycles Upper Boundary estimated cycles | (%) | Instructions | Instructions Results instructions | (Δ%) | Instructions Upper Boundary instructions | (%) | L1 Accesses | L1 Accesses Results accesses | (Δ%) | L1 Accesses Upper Boundary accesses | (%) | L2 Accesses | L2 Accesses Results accesses | (Δ%) | L2 Accesses Upper Boundary accesses | (%) | RAM Accesses | RAM Accesses Results accesses | (Δ%) | RAM Accesses Upper Boundary accesses | (%) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| client_sv2_handle_message_common | ✅ (view plot) | 2098.000 (+2.55%) | 2105.692 (99.63%) | ✅ (view plot) | 469.000 (+0.51%) | 479.906 (97.73%) | ✅ (view plot) | 728.000 (+0.25%) | 747.095 (97.44%) | ✅ (view plot) | 8.000 (+13.58%) | 9.735 (82.18%) | ✅ (view plot) | 38.000 (+3.55%) | 38.329 (99.14%) |
| client_sv2_handle_message_mining | ✅ (view plot) | 8134.000 (+0.04%) | 8195.494 (99.25%) | ✅ (view plot) | 2133.000 (+1.65%) | 2159.044 (98.79%) | ✅ (view plot) | 3159.000 (+1.97%) | 3200.791 (98.69%) | ✅ (view plot) | 36.000 (-13.12%) | 47.994 (75.01%) | ✅ (view plot) | 137.000 (-0.63%) | 139.725 (98.05%) |
| client_sv2_mining_message_submit_standard | ✅ (view plot) | 6322.000 (-0.41%) | 6486.317 (97.47%) | ✅ (view plot) | 1750.000 (+0.09%) | 1760.412 (99.41%) | ✅ (view plot) | 2552.000 (+0.22%) | 2566.100 (99.45%) | ✅ (view plot) | 19.000 (-11.36%) | 25.598 (74.23%) | ✅ (view plot) | 105.000 (-0.54%) | 109.728 (95.69%) |
| client_sv2_mining_message_submit_standard_serialize | ✅ (view plot) | 14769.000 (+1.05%) | 14824.671 (99.62%) | ✅ (view plot) | 4694.000 (+0.03%) | 4704.412 (99.78%) | ✅ (view plot) | 6754.000 (-0.03%) | 6774.776 (99.69%) | ✅ (view plot) | 49.000 (+0.09%) | 51.724 (94.73%) | ✅ (view plot) | 222.000 (+2.04%) | 223.598 (99.29%) |
| client_sv2_mining_message_submit_standard_serialize_deserialize | ✅ (view plot) | 27350.000 (+0.30%) | 27424.617 (99.73%) | ✅ (view plot) | 10537.000 (+0.02%) | 10547.412 (99.90%) | ✅ (view plot) | 15335.000 (+0.01%) | 15352.219 (99.89%) | ✅ (view plot) | 86.000 (-2.37%) | 93.769 (91.71%) | ✅ (view plot) | 331.000 (+0.78%) | 333.287 (99.31%) |
| client_sv2_open_channel | ✅ (view plot) | 4481.000 (-0.13%) | 4639.475 (96.58%) | ✅ (view plot) | 1461.000 (+0.16%) | 1471.906 (99.26%) | ✅ (view plot) | 2156.000 (+0.25%) | 2170.454 (99.33%) | ✅ (view plot) | 10.000 (-16.67%) | 16.318 (61.28%) | ✅ (view plot) | 65.000 (-0.07%) | 69.088 (94.08%) |
| client_sv2_open_channel_serialize | ✅ (view plot) | 14186.000 (+0.90%) | 14239.434 (99.62%) | ✅ (view plot) | 5064.000 (+0.05%) | 5074.906 (99.79%) | ✅ (view plot) | 7321.000 (+0.04%) | 7338.264 (99.76%) | ✅ (view plot) | 36.000 (-8.31%) | 43.026 (83.67%) | ✅ (view plot) | 191.000 (+2.14%) | 192.537 (99.20%) |
| client_sv2_open_channel_serialize_deserialize | ✅ (view plot) | 22432.000 (+0.09%) | 22559.068 (99.44%) | ✅ (view plot) | 7979.000 (+0.03%) | 7989.906 (99.86%) | ✅ (view plot) | 11617.000 (+0.04%) | 11636.110 (99.84%) | ✅ (view plot) | 70.000 (-2.60%) | 76.827 (91.11%) | ✅ (view plot) | 299.000 (+0.23%) | 302.398 (98.88%) |
| client_sv2_setup_connection | ✅ (view plot) | 4779.000 (+1.24%) | 4780.083 (99.98%) | ✅ (view plot) | 1502.000 (+0.16%) | 1512.906 (99.28%) | ✅ (view plot) | 2274.000 (+0.12%) | 2292.319 (99.20%) | ✅ (view plot) | 11.000 (-8.66%) | 14.576 (75.47%) | 🚨 (view plot | view alert) | 70.000 (+2.55%) | 69.866 (100.19%) |
| client_sv2_setup_connection_serialize | ✅ (view plot) | 16300.000 (+0.93%) | 16353.389 (99.67%) | ✅ (view plot) | 5963.000 (+0.04%) | 5973.906 (99.82%) | ✅ (view plot) | 8655.000 (-0.01%) | 8675.467 (99.76%) | ✅ (view plot) | 45.000 (-0.67%) | 49.547 (90.82%) | ✅ (view plot) | 212.000 (+2.09%) | 213.286 (99.40%) |
| client_sv2_setup_connection_serialize_deserialize | ✅ (view plot) | 35544.000 (+0.31%) | 35591.378 (99.87%) | ✅ (view plot) | 14806.000 (+0.02%) | 14816.906 (99.93%) | ✅ (view plot) | 21744.000 (-0.01%) | 21763.851 (99.91%) | ✅ (view plot) | 100.000 (+2.54%) | 104.510 (95.68%) | ✅ (view plot) | 380.000 (+0.75%) | 381.845 (99.52%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
Contributor
|
| Report | Thu, March 21, 2024 at 20:36:33 UTC |
| Project | Stratum v2 (SRI) |
| Branch | 767/merge |
| Testbed | sv1 |
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|
| client-submit-serialize | ✅ (view plot) | 6915.300 (+0.63%) | 7192.411 (96.15%) |
| client-submit-serialize-deserialize | ✅ (view plot) | 7927.400 (+1.06%) | 8242.114 (96.18%) |
| client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle | ✅ (view plot) | 8471.800 (+0.89%) | 8744.130 (96.89%) |
| client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle | ✅ (view plot) | 902.570 (-0.49%) | 944.291 (95.58%) |
| client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize | ✅ (view plot) | 693.740 (-1.33%) | 757.561 (91.58%) |
| client-sv1-authorize-serialize/client-sv1-authorize-serialize | ✅ (view plot) | 254.710 (-0.21%) | 294.292 (86.55%) |
| client-sv1-get-authorize/client-sv1-get-authorize | ✅ (view plot) | 159.650 (-0.05%) | 173.624 (91.95%) |
| client-sv1-get-submit | ✅ (view plot) | 6805.700 (+2.11%) | 6971.795 (97.62%) |
| client-sv1-get-subscribe/client-sv1-get-subscribe | ✅ (view plot) | 280.210 (-0.89%) | 301.123 (93.05%) |
| client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle | ✅ (view plot) | 746.270 (-0.53%) | 784.548 (95.12%) |
| client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize | ✅ (view plot) | 621.630 (+1.33%) | 636.316 (97.69%) |
| client-sv1-subscribe-serialize/client-sv1-subscribe-serialize | ✅ (view plot) | 209.760 (-0.43%) | 222.758 (94.17%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
Contributor
|
| Report | Thu, March 21, 2024 at 20:36:34 UTC |
| Project | Stratum v2 (SRI) |
| Branch | release-bin |
| Testbed | sv2 |
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|
| client_sv2_handle_message_common | ✅ (view plot) | 44.494 (+0.41%) | 45.127 (98.60%) |
| client_sv2_handle_message_mining | 🚨 (view plot | view alert) | 81.335 (+16.70%) | 80.161 (101.46%) |
| client_sv2_mining_message_submit_standard | ✅ (view plot) | 14.657 (-0.19%) | 14.879 (98.51%) |
| client_sv2_mining_message_submit_standard_serialize | ✅ (view plot) | 268.030 (-0.09%) | 280.928 (95.41%) |
| client_sv2_mining_message_submit_standard_serialize_deserialize | ✅ (view plot) | 573.180 (-2.10%) | 613.589 (93.41%) |
| client_sv2_open_channel | ✅ (view plot) | 178.170 (+6.51%) | 178.412 (99.86%) |
| client_sv2_open_channel_serialize | ✅ (view plot) | 278.730 (-3.18%) | 301.038 (92.59%) |
| client_sv2_open_channel_serialize_deserialize | ✅ (view plot) | 371.360 (-1.45%) | 404.697 (91.76%) |
| client_sv2_setup_connection | ✅ (view plot) | 154.030 (-4.86%) | 168.206 (91.57%) |
| client_sv2_setup_connection_serialize | ✅ (view plot) | 496.470 (+4.87%) | 501.920 (98.91%) |
| client_sv2_setup_connection_serialize_deserialize | ✅ (view plot) | 950.130 (-3.67%) | 1068.423 (88.93%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
Contributor
|
| Report | Thu, March 21, 2024 at 20:36:32 UTC |
| Project | Stratum v2 (SRI) |
| Branch | release-bin |
| Testbed | sv1 |
| Benchmark | Estimated Cycles | Estimated Cycles Results estimated cycles | (Δ%) | Estimated Cycles Upper Boundary estimated cycles | (%) | Instructions | Instructions Results instructions | (Δ%) | Instructions Upper Boundary instructions | (%) | L1 Accesses | L1 Accesses Results accesses | (Δ%) | L1 Accesses Upper Boundary accesses | (%) | L2 Accesses | L2 Accesses Results accesses | (Δ%) | L2 Accesses Upper Boundary accesses | (%) | RAM Accesses | RAM Accesses Results accesses | (Δ%) | RAM Accesses Upper Boundary accesses | (%) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| get_authorize | ✅ (view plot) | 8492.000 (+0.44%) | 8509.073 (99.80%) | ✅ (view plot) | 3746.000 (-0.00%) | 3759.496 (99.64%) | ✅ (view plot) | 5252.000 (+0.02%) | 5273.950 (99.58%) | ✅ (view plot) | 4.000 (-43.90%) | 10.170 (39.33%) | ✅ (view plot) | 92.000 (+1.63%) | 92.209 (99.77%) |
| get_submit | ✅ (view plot) | 95597.000 (+0.04%) | 95642.732 (99.95%) | ✅ (view plot) | 59439.000 (-0.00%) | 59479.455 (99.93%) | ✅ (view plot) | 85352.000 (-0.01%) | 85423.891 (99.92%) | ✅ (view plot) | 54.000 (-1.35%) | 58.504 (92.30%) | ✅ (view plot) | 285.000 (+0.43%) | 286.433 (99.50%) |
| get_subscribe | ✅ (view plot) | 8063.000 (+0.77%) | 8086.288 (99.71%) | ✅ (view plot) | 2841.000 (+0.03%) | 2847.140 (99.78%) | ✅ (view plot) | 3968.000 (-0.00%) | 3979.949 (99.70%) | ✅ (view plot) | 14.000 (-4.73%) | 17.676 (79.20%) | ✅ (view plot) | 115.000 (+1.65%) | 115.565 (99.51%) |
| serialize_authorize | ✅ (view plot) | 12211.000 (+0.06%) | 12299.055 (99.28%) | ✅ (view plot) | 5317.000 (-0.00%) | 5330.496 (99.75%) | ✅ (view plot) | 7416.000 (+0.03%) | 7435.148 (99.74%) | ✅ (view plot) | 7.000 (-31.78%) | 13.008 (53.81%) | ✅ (view plot) | 136.000 (+0.45%) | 137.863 (98.65%) |
| serialize_deserialize_authorize | ✅ (view plot) | 24532.000 (+0.14%) | 24575.584 (99.82%) | ✅ (view plot) | 9898.000 (-0.01%) | 9923.567 (99.74%) | ✅ (view plot) | 13957.000 (-0.02%) | 14001.969 (99.68%) | ✅ (view plot) | 36.000 (-3.72%) | 40.782 (88.28%) | ✅ (view plot) | 297.000 (+0.43%) | 297.797 (99.73%) |
| serialize_deserialize_handle_authorize | ✅ (view plot) | 30251.000 (+0.16%) | 30285.667 (99.89%) | ✅ (view plot) | 12101.000 (-0.00%) | 12114.496 (99.89%) | ✅ (view plot) | 17121.000 (+0.00%) | 17144.504 (99.86%) | ✅ (view plot) | 57.000 (-5.00%) | 64.552 (88.30%) | ✅ (view plot) | 367.000 (+0.49%) | 367.945 (99.74%) |
| serialize_deserialize_handle_submit | ✅ (view plot) | 126430.000 (-0.02%) | 126537.861 (99.91%) | ✅ (view plot) | 73224.000 (-0.00%) | 73264.557 (99.94%) | ✅ (view plot) | 104940.000 (-0.01%) | 105015.384 (99.93%) | ✅ (view plot) | 126.000 (+3.76%) | 129.101 (97.60%) | ✅ (view plot) | 596.000 (-0.17%) | 600.228 (99.30%) |
| serialize_deserialize_handle_subscribe | ✅ (view plot) | 27575.000 (+0.25%) | 27595.320 (99.93%) | ✅ (view plot) | 9643.000 (+0.01%) | 9649.140 (99.94%) | ✅ (view plot) | 13635.000 (+0.00%) | 13646.426 (99.92%) | ✅ (view plot) | 65.000 (-1.90%) | 70.240 (92.54%) | ✅ (view plot) | 389.000 (+0.55%) | 389.770 (99.80%) |
| serialize_deserialize_submit | ✅ (view plot) | 115019.000 (-0.03%) | 115156.055 (99.88%) | ✅ (view plot) | 68001.000 (-0.01%) | 68082.114 (99.88%) | ✅ (view plot) | 97554.000 (-0.01%) | 97695.068 (99.86%) | ✅ (view plot) | 70.000 (+2.42%) | 71.340 (98.12%) | ✅ (view plot) | 489.000 (-0.17%) | 492.290 (99.33%) |
| serialize_deserialize_subscribe | ✅ (view plot) | 22964.000 (+0.23%) | 22974.129 (99.96%) | ✅ (view plot) | 8195.000 (+0.01%) | 8203.481 (99.90%) | ✅ (view plot) | 11539.000 (-0.00%) | 11554.738 (99.86%) | ✅ (view plot) | 38.000 (-3.00%) | 44.429 (85.53%) | ✅ (view plot) | 321.000 (+0.52%) | 321.444 (99.86%) |
| serialize_submit | ✅ (view plot) | 99880.000 (+0.00%) | 99989.107 (99.89%) | ✅ (view plot) | 61483.000 (-0.00%) | 61523.455 (99.93%) | ✅ (view plot) | 88200.000 (-0.00%) | 88268.428 (99.92%) | ✅ (view plot) | 54.000 (-2.13%) | 57.638 (93.69%) | ✅ (view plot) | 326.000 (+0.11%) | 328.429 (99.26%) |
| serialize_subscribe | ✅ (view plot) | 11358.000 (+0.27%) | 11429.792 (99.37%) | ✅ (view plot) | 4188.000 (+0.02%) | 4194.140 (99.85%) | ✅ (view plot) | 5828.000 (+0.02%) | 5837.775 (99.83%) | ✅ (view plot) | 14.000 (-6.94%) | 17.493 (80.03%) | ✅ (view plot) | 156.000 (+0.65%) | 157.950 (98.77%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
plebhash
force-pushed
the
release-bin
branch
5 times, most recently
from
3b541e8 to
bfbcdbb
Compare
Collaborator
|
@plebhash I assume all of these PR's are needed for Milestone 4 release specifically, documentation included, so I've added them to Milestone 4. If some of them aren't critical, let me know and I can push them to Milestone 5, though to me it seems they're all needed in order to do a release. |
Member
Author
Ideally #766 and #767 should go together #771 is not critical |
plebhash
force-pushed
the
release-bin
branch
4 times, most recently
from
67d3bcd to
a2b4918
Compare
pavlenex
approved these changes
Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a mock release on my fork as a demo of how the Github Actions from this PR work. You can find it at https://github.com/plebhash/stratum/releases/tag/v1.0.0
It contains binaries for all roles:
jd_clientjd_servermining_proxy_sv2pool_sv2translator_sv2each role has binaries available for the following platforms:
x86_64-linux-gnu(Linux)x86_64-apple-darwin(MacOS x86-64)arm64-apple-darwin(MacOS Apple Silicon)The idea is to always add release notes with a changelog, which is basically a list of changes since the last release tag.
As company PRs, there's also #766 and #771