generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 17
Add bounded integer types and expressions to Lambda #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joscoh
wants to merge
21
commits into
main
Choose a base branch
from
josh/bounded
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instantiate with unit as default for compatibiity
Bitvectors are no longer a special case in LTy but rather an instance of a type restriction/metadata
Test cases for wf generation Fix a few bugs, refactor and improve comments in code Some AI-generated tests for more bound cases
Change List -> Set to avoid duplicates Remove quantifiers from output wf conditions when possible Add guard_msgs for tests Split tests into separate file Fix bug in abstraction case
Better description of overall algorithm Mark definitions private Comments for most functions Other minor code quality improvements
Still special case but need this way so that we can have polymorphic non-restricted type applications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds bounded integer type to
LMonoTyand parameterizesLExprTwith this type to produce Lambda expressions with bounded ints. FileDL/Bounded/BExpr.leancontains an algorithm (with explanation) to translate these terms to ordinary Lambda expressions (with bound assumptions added) and to produce well-formedness conditions. The rest of the changes are simply a result of adding another parameter toLMonoTy.This PR allows the definitions of types like
nat = {x : int | 0 <= x}and expressions likeforall (x: nat), x + 1 > 0. This gets translated to the semantically equivalentforall (x: int), 0 <= x -> x + 1 > 0. For more examples which show the variety of features supported (e.g. external operators with bounded types), see the test cases inStrataTest/DL/Bounded/BExprTest.lean.Currently, this omits the necessary changes to the typing and type inference of Lambda; these will need to be made polymorphic in the newly added
ExtraRestrictparameter. Once this piece is complete, the default parameter ofLMonoTywill beEmptyrather thanBoundTyRestrict, resulting in no overall change to Lambda.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.