Introduce source ranges and cleanup error handling. #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehendrix
force-pushed
the
jhx/errors
branch
from
daf53e3 to
de896f2
Compare
joehendrix
requested review from
a team,
aqjune-aws and
shigoel
as code owners
atomb
previously approved these changes
Sep 26, 2025
Contributor
atomb
left a comment
atomb
left a comment
There was a problem hiding this comment.
I like this, though I had one minor terminology comment. And could you update the PR description before merging?
joehendrix
force-pushed
the
jhx/errors
branch
3 times, most recently
from
1c291d6 to
68b9c6e
Compare
joehendrix
force-pushed
the
jhx/errors
branch
from
68b9c6e to
6163590
Compare
joehendrix
changed the title
joehendrix
changed the title
joehendrix
changed the title
atomb
approved these changes
Oct 2, 2025
Contributor
|
I would like to see whether the newly embedded source locations work - could you instruct me how I can test it? |
Contributor
Author
|
The LoadDialect test uses the error locations to print error messages. The source locations are still restricted to the info trees in this PR. #112 adds support to all the DDM types, but is a large PR, and I am merging in pieces (including this one). We can have better tests once #112 is finally merged in. |
aqjune-aws
approved these changes
Oct 6, 2025
Contributor
aqjune-aws
left a comment
aqjune-aws
left a comment
There was a problem hiding this comment.
I see - thanks for clarification!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a datatype for a range of characters in a source file. It will be used for embedding source information in the AST for #112 , but is currently only being added to info trees.
This PR also removes the extra syntax elements from error handling as messages contain source information.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.