-
Notifications
You must be signed in to change notification settings - Fork 17
Add Typescript Basic features #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Typescript Basic features #141
Conversation
…hout support for inc/dec ops Signed-off-by: YingZhu <[email protected]>
Signed-off-by: YingZhu <[email protected]>
This reverts commit 7ce97fa.
Signed-off-by: YingZhu <[email protected]>
Signed-off-by: YingZhu <[email protected]>
Extend the dialect of for statement in Typescript
…hout support for inc/dec ops Signed-off-by: YingZhu <[email protected]>
Signed-off-by: YingZhu <[email protected]>
Signed-off-by: YingZhu <[email protected]>
Signed-off-by: YingZhu <[email protected]>
Julia/tsbasic: Add While loop for Strata
…sponding test Signed-off-by: YingZhu <[email protected]>
Ex10si0n/array
| def intEqFunc [Coe String Ident] : LFunc Ident := | ||
| binaryPredicate "Int.Eq" .int | ||
| (some (binOpCeval Int Bool LExpr.denoteInt (fun x y => x == y) .bool)) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lambda has a general-purpose .eq constructor that I would think would make this unnecessary. Is there an issue with using that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please clarify that we can use the built-in Lambda.LExpr.eq here? See link to code: https://github.com/strata-org/Strata/pull/141/files/9963ca05def0a0856478cb2939fb69cfca7086ac#r2399812517
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Aaron and Shilpi, this is to support the "==" operator based on its original definition.
| "==" => Heap.HExpr.app (Heap.HExpr.app (Heap.HExpr.deferredOp "Int.Eq" none) lhs) rhs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll focus on === for now.
feat: add support for str.length
Yuyang/break in for
[feat] `continue` statement in for loop
Julia/arrowfunc: Arrow function expression
Julia/tsbasic: Enhanced Function - Function Expression
Yuyang/nested func
ff2f248
into
strata-org:typescript-frontend
Issue #, if available:
Description of changes:
Adding support to
while,for,continue, andbreakBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.