Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include APP_KEYS in Heroku Deployment Guide - fix #807 #838

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

dsfaccini
Copy link
Contributor

What does it do?

Describe the technical changes you did.

Under title 5. Create your Strapi server config for production
Update env/production/server.js to include app -> keys object
Include bash command to set APP_KEYS environment variable on Heroku

Why is it needed?

Solves the error:
Error: Middleware "strapi::session": App keys are required. Please set app.keys in config/server.js (ex: keys: ['myKeyA', 'myKeyB'])

Related issue(s)/PR(s)

The Issue is here #807

- Specify if the PR is in WIP (work in progress) state or ready to be merged

The fix is ready to be merged

Under title 5. Create your Strapi server config for production
Update env/production/server.js to include app -> keys object
Include bash command to set APP_KEYS environment variable on Heroku
@strapi-cla
Copy link

strapi-cla commented Apr 6, 2022

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented Apr 6, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/strapijs/documentation/322TfZsMW55snnf3vJUDzgAAeoBo
✅ Preview: https://documentation-git-fork-dsfaccini-patch-1-strapijs.vercel.app

@stb13579 stb13579 requested review from petersg83 and stb13579 April 7, 2022 04:10
@stb13579 stb13579 self-assigned this Apr 7, 2022
@stb13579 stb13579 linked an issue Apr 7, 2022 that may be closed by this pull request
@stb13579
Copy link
Contributor

stb13579 commented Apr 7, 2022

Hello @dsfaccini, Thank you for your contribution. I will review it by the end of this week.

@stb13579
Copy link
Contributor

stb13579 commented Apr 7, 2022

@dsfaccini If you can address the one comment on this PR I will merge it ASAP. Thanks for the contribution!

Copy link
Contributor

@stb13579 stb13579 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@petersg83 petersg83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@stb13579 stb13579 added source: Dev Docs PRs/issues targeting the Developer Docs issue: doc request Issues that require adding new content, possibly with some prior research target: v4 Documentation PRs/issues targeting content from docs.strapi.io (main branch). target: next Documentation PRs/issues targeting content from docs-next.strapi.io (next branch) size: small If the PR includes only 1 file with <10 lines of text or a small code fix labels Apr 8, 2022
@stb13579 stb13579 merged commit 0c33ecd into strapi:main Apr 8, 2022
@pwizla pwizla removed the target: next Documentation PRs/issues targeting content from docs-next.strapi.io (next branch) label May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: doc request Issues that require adding new content, possibly with some prior research size: small If the PR includes only 1 file with <10 lines of text or a small code fix source: Dev Docs PRs/issues targeting the Developer Docs target: v4 Documentation PRs/issues targeting content from docs.strapi.io (main branch).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heroku deployment with APP_KEYS
5 participants