chore: sync workflow templates - #1716
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
✅ Deploy Preview for stranske-trip-planner canceled.
|
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (7)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
@coderabbitai review |
|
@codex review |
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5ab6565868
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| _NODE_SUFFIX = re.compile(r"::.+$") # pytest node ids: tests/x.py::test_y | ||
| _ORIGINAL_ISSUE_BLOCK_RE = re.compile( | ||
| r"<details\b[^>]*>\s*<summary>Original Issue</summary>\s*" | ||
| r"(?P<fence>`{3,})text\s*\n(?P<inner>.*?)\n(?P=fence)\s*</details>", |
There was a problem hiding this comment.
Accept tilde-fenced provenance blocks
When an existing formatted issue uses a ~~~text archive, this regex leaves the archived body visible even though scripts/langchain/issue_formatter.py:480-483 explicitly recognizes tilde-fenced Original Issue blocks. If that archive contains three stale paths, validate(..., repo_root=...) counts them as live citations and incorrectly marks an otherwise conforming issue as not agent-processable. Accept both supported fence characters in the Workflows source before syncing this validator.
AGENTS.md reference: AGENTS.md:L22-L22
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Confirmed as source-owned. The bounded fix is open in stranske/Workflows#3064 with root/template parity and a tilde-fence regression. This generated PR remains unmergeable; Maint 68 will refresh this stable candidate in place after the source fix merges.
5ab6565 to
63e9dde
Compare
|
@codex review |
|
@coderabbitai review |
|
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
63e9dde to
744abed
Compare
|
@codex review |
|
@coderabbitai review |
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 744abed6bb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| inputs: { | ||
| pr_number: String(pr.number), | ||
| force_retry: 'true', |
There was a problem hiding this comment.
Limit forced retries to due authority challenges
On every scheduled sweep, this now sets force_retry for every non-draft agent-labelled PR, not just the dueChallenge case. In agents-81-gate-followups.yml, that flag bypasses non-success Gate states and resets both no-progress counters, so an ordinary stalled PR can rerun despite a failed/cancelled Gate and repeatedly avoid the zero-activity/progress-review stop logic. Preserve the previous normal re-evaluation for ordinary PRs and force only the explicitly due recovery path; make the source-of-truth fix in Workflows before syncing it here.
AGENTS.md reference: AGENTS.md:L65-L77
Useful? React with 👍 / 👎.
| if (dueChallenge) { | ||
| challenged += 1; | ||
| core.info( | ||
| `PR #${pr.number}: independently rechecking due authority claim ` + | ||
| `(due ${dueChallenge.dueAt}; ${dueChallenge.nextAction || dueChallenge.key || 'no detail'})`, | ||
| ); | ||
| } |
There was a problem hiding this comment.
Implement an outcome for due authority challenges
When an auth failure creates a due authority claim, this branch only increments a counter and logs it; the following dispatch is identical whether dueChallenge is present or null, and no challenge context or result is passed downstream. A repeated auth failure therefore just recreates challenge_due_at and leaves agent:needs-attention indefinitely, without ever confirming the boundary, recording an exact human action, or applying needs-human. Route due claims through an actual independent challenge/terminal decision in the Workflows source before syncing.
AGENTS.md reference: AGENTS.md:L65-L77
Useful? React with 👍 / 👎.
|
Source-owned findings accepted and grouped in stranske/Workflows#3066. This generated PR remains blocked; a no-filter Maint 68 canary will refresh this same candidate PR after the source fix merges. |
744abed to
09d6c8a
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 09d6c8a22b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
09d6c8a to
64bc1b3
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 64bc1b3855
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (core) core.warning(`Failed to add needs-human label: ${error.message}`); | ||
| if (core) core.warning(`Failed to add ${escalationDisposition} routing label: ${error.message}`); | ||
| } | ||
| if (escalationDisposition === 'automation-retry' && !stop) { |
There was a problem hiding this comment.
Run recovery for automation-owned stop states
For terminal non-auth states such as round-budget-exhausted, selectEscalationDisposition returns automation-retry, but this !stop condition prevents the only recovery dispatch from running. The added agent:retry label cannot resolve this case because evaluation checks the hard iteration limit before choosing work, and each hourly non-forced sweep reaches the same stop again, leaving the PR permanently automation-owned with neither recovery nor a human escalation; route these stop states to an actual bounded fallback in the Workflows source.
AGENTS.md reference: AGENTS.md:L65-L77
Useful? React with 👍 / 👎.
64bc1b3 to
1565572
Compare
Automated sync from stranske/Workflows Template hash: 7a99d523d28c Changes synced from sync-manifest.yml
1565572 to
35d07df
Compare
Sync Summary
Files Updated
Files Skipped
Review Checklist
Source: stranske/Workflows
Source SHA:
590ae8053b0ac6ce1f5efd36e9379f240d794e0fTemplate hash:
7a99d523d28cConsumer-sync plan ID:
sha256:7a99d523d28c8148ab3219144e30e97258a6127dae3b08a9c6937b5da1f0aa78Sync phase:
canarySync branch:
sync/workflows-candidateConsumer repo:
stranske/trip-plannerManifest:
.github/sync-manifest.ymlautofix: false