Skip to content

chore: sync workflow templates - #1405

Merged
stranske merged 1 commit into
mainfrom
sync/workflows-94b2d167cb49
Jun 16, 2026
Merged

stranske merged 1 commit into
mainfrom
sync/workflows-94b2d167cb49

Conversation

@stranske

@stranske stranske commented Jun 16, 2026

Copy link
Copy Markdown
Owner

Sync Summary

Files Updated

  • agents-auto-pilot.yml: Auto-pilot - end-to-end automation orchestrator (format → optimize → agent → verify)
  • agents-weekly-metrics.yml: Weekly metrics - aggregates auto-pilot, keepalive, autofix and verifier metrics into summary reports

Files Skipped

  • pr-00-gate.yml: File exists and sync_mode is create_only
  • ci.yml: File exists and sync_mode is create_only
  • renovate.json: File exists and sync_mode is create_only
  • cross-repo-smoke.yml: File exists and sync_mode is create_only
  • .github/scripts/package.json: Repo installs .github/scripts dependencies from package-lock.json and forbids tracked node_modules
  • .github/scripts/node_modules/minimatch: Repo installs .github/scripts dependencies from package-lock.json and forbids tracked node_modules
  • .github/scripts/node_modules/brace-expansion: Repo installs .github/scripts dependencies from package-lock.json and forbids tracked node_modules
  • .github/scripts/node_modules/balanced-match: Repo installs .github/scripts dependencies from package-lock.json and forbids tracked node_modules
  • llm_slots.json: None

Review Checklist

  • CI passes with updated workflows
  • No repo-specific customizations were overwritten

Source: stranske/Workflows
Source SHA: b4f41c99919965c91d9f4f42460cc21bb35bd24a
Template hash: 94b2d167cb49
Sync branch: sync/workflows-94b2d167cb49
Consumer repo: stranske/trip-planner
Manifest: .github/sync-manifest.yml

Summary by CodeRabbit

  • Chores
    • Updated Node.js runtime from version 20 to version 24 in CI/CD workflows to ensure compatibility with the latest runtime environment.

Automated sync from stranske/Workflows
Template hash: 94b2d167cb49

Changes synced from sync-manifest.yml
@stranske stranske added sync Automated sync from Workflows automated Automated sync from Workflows labels Jun 16, 2026
@netlify

netlify Bot commented Jun 16, 2026

Copy link
Copy Markdown

Deploy Preview for stranske-trip-planner canceled.

Name Link
🔨 Latest commit f0ed46f
🔍 Latest deploy log https://app.netlify.com/projects/stranske-trip-planner/deploys/6a31b79bbb5411000825a030

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7eb7be61-4136-4875-87b7-3bb97c84da97

📥 Commits

Reviewing files that changed from the base of the PR and between 5f8cfc3 and f0ed46f.

📒 Files selected for processing (2)
  • .github/workflows/agents-auto-pilot.yml
  • .github/workflows/agents-weekly-metrics.yml
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • stranske/Workflows (auto-detected)
📜 Recent review details
🧰 Additional context used
📓 Path-based instructions (5)
{pyproject.toml,.github/workflows/**/*.{yml,yaml}}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Check both pyproject.toml ([tool.coverage.report] fail_under) AND workflow files for coverage-min settings; ensure these match or the lower value will be the effective threshold

Files:

  • .github/workflows/agents-weekly-metrics.yml
  • .github/workflows/agents-auto-pilot.yml
.github/workflows/**/*.{yml,yaml}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

For GitHub Actions workflow startup_failure errors with zero jobs, check for invalid YAML syntax, top-level permissions: block on workflow_call reusable workflows (which conflicts with caller permissions), invalid permission scopes, or circular workflow references

Files:

  • .github/workflows/agents-weekly-metrics.yml
  • .github/workflows/agents-auto-pilot.yml
.github/workflows/*.yml

📄 CodeRabbit inference engine (CLAUDE.md)

In consumer repositories, reference reusable workflows with @main unless intentionally pinning to an exact commit SHA for a controlled reason

Files:

  • .github/workflows/agents-weekly-metrics.yml
  • .github/workflows/agents-auto-pilot.yml
.github/workflows/agents-*.yml

📄 CodeRabbit inference engine (CLAUDE.md)

agents-*.yml workflows should be fixed in stranske/Workflows, not locally

Synced workflows with agents-*.yml filenames should be fixed in stranske/Workflows, not edited locally

Files:

  • .github/workflows/agents-weekly-metrics.yml
  • .github/workflows/agents-auto-pilot.yml
**/.github/workflows/*.yml

📄 CodeRabbit inference engine (AGENTS.md)

Reference reusable workflows with @main unless intentionally pinning to an exact commit SHA for a controlled reason

Files:

  • .github/workflows/agents-weekly-metrics.yml
  • .github/workflows/agents-auto-pilot.yml
🔀 Multi-repo context stranske/Workflows

Based on my exploration of the stranske/Workflows repository, I have gathered sufficient cross-repo context to inform the review. Here are my findings:

Linked repositories findings

stranske/Workflows [::stranske/Workflows::]

Node.js 24 Upgrade Context:

The Node.js version bump from 20 to 24 in both agents-auto-pilot.yml and agents-weekly-metrics.yml was introduced in a deliberate, tested upgrade:

  • Source commit: b4f41c99919965c91d9f4f42460cc21bb35bd24a with commit message: "chore(deps): update dependency node to v24 (#2396)" and "fix: align node 24 workflow gates" [::stranske/Workflows::]
  • Change type: Renovate-managed dependency update with workflow alignment fixes
  • Validation: The upgrade is validated by explicit test assertions in tests/workflows/test_workflow_agents_consolidation.py:418 that require 'node-version: "24"' to be present in both workflows [::stranske/Workflows::]
  • Test evidence: Line 419 assertion message: "Weekly metrics must run its Node helpers on an explicit Node 24 runtime" [::stranske/Workflows::]

Breaking Change Status:

  • The CHANGELOG.md explicitly states: "### Breaking changes - None. Breaking changes will be prefixed with BREAKING and scheduled in line with the compatibility policy." [::stranske/Workflows::]
  • However, this represents a runtime requirement change from Node 20 to Node 24, which is a material shift in the execution environment

Configuration Details:

  • Both workflows use actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6 (pinned to commit SHA) with node-version: "24" [::stranske/Workflows::]
  • The Node 24 requirement is specific to the agents infrastructure workflows — the template templates/ci-node-basic.yml references Node versions ["18", "20", "22"] for general CI use [::stranske/Workflows::]

Key Implication for Review:

The Node.js 24 upgrade is intentional and thoroughly validated in the source repository. Any repository receiving this sync must ensure:

  1. CI/CD environments support Node.js 24 (LTS release as of this sync)
  2. Any Node.js scripts or dependencies in the workflow execution path are compatible with Node 24
  3. The setup-api-client action and any pinned GitHub API dependencies work with Node 24
🔇 Additional comments (2)
.github/workflows/agents-auto-pilot.yml (1)

166-166: LGTM!

.github/workflows/agents-weekly-metrics.yml (1)

50-50: LGTM!


📝 Walkthrough

Walkthrough

Two GitHub Actions workflow files (agents-auto-pilot.yml and agents-weekly-metrics.yml) each have their actions/setup-node step updated to use Node.js 24 instead of 20.

Changes

Node.js Version Bump

Layer / File(s) Summary
Node.js 20 → 24 in both workflows
.github/workflows/agents-auto-pilot.yml, .github/workflows/agents-weekly-metrics.yml
The node-version value in the actions/setup-node step is changed from '20' to '24' in both workflow files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title "chore: sync workflow templates" accurately reflects the main change—synchronizing workflow template files from an external repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/workflows-94b2d167cb49

Comment @coderabbitai help to get the list of available commands and usage tips.

@stranske
stranske merged commit 097f589 into main Jun 16, 2026
128 of 135 checks passed
@stranske
stranske deleted the sync/workflows-94b2d167cb49 branch June 16, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated Automated sync from Workflows sync Automated sync from Workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant