Skip to content

Add keepalive loop metrics emission#98

Merged
stranske merged 2 commits intocodex/issue-93from
codex/github-mention-chorecodex-bootstrap-pr-for-issue-#93
Dec 24, 2025
Merged

Add keepalive loop metrics emission#98
stranske merged 2 commits intocodex/issue-93from
codex/github-mention-chorecodex-bootstrap-pr-for-issue-#93

Conversation

@stranske
Copy link
Copy Markdown
Owner

Summary

  • capture workflow start timestamp and compute keepalive iteration metrics
  • emit structured keepalive metrics to GITHUB_STEP_SUMMARY and append ndjson records
  • persist keepalive metrics artifact with 30-day retention for later aggregation

Testing

  • python - <<'PY'\nimport yaml\npath='.github/workflows/agents-keepalive-loop.yml'\nwith open(path, 'r', encoding='utf-8') as f:\n yaml.safe_load(f)\nprint('ok')\nPY

Codex Task

Copilot AI review requested due to automatic review settings December 24, 2025 11:49
@stranske stranske merged commit e45db7b into codex/issue-93 Dec 24, 2025
12 checks passed
@stranske stranske deleted the codex/github-mention-chorecodex-bootstrap-pr-for-issue-#93 branch December 24, 2025 11:49
@stranske stranske temporarily deployed to agent-high-privilege December 24, 2025 11:50 — with GitHub Actions Inactive
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive metrics collection and emission capabilities to the agents keepalive loop workflow. The changes enable tracking of workflow execution time, iteration counts, task completion progress, and loop termination reasons for later analysis and aggregation.

  • Captures workflow start timestamp at the beginning of the evaluate job
  • Computes and emits structured keepalive metrics including duration, iteration count, task progress, and stop reason
  • Persists metrics as NDJSON artifacts with 30-day retention for downstream aggregation
Comments suppressed due to low confidence (1)

.github/workflows/agents-keepalive-loop.yml:127

  • The regex pattern allows negative numbers for tasks_total and tasks_unchecked, which doesn't make logical sense for task counts. Consider using the pattern ^[0-9]+$ (without the optional minus sign) to match only non-negative integers, consistent with the START_TS validation pattern.

  run-codex:

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown
Contributor

Automated Status Summary

Head SHA: dc5bac0
Latest Runs: ⏳ pending — Gate
Required contexts: Gate / gate, Health 45 Agents Guard / Enforce agents workflow protections
Required: core tests (3.11): ⏳ pending, core tests (3.12): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job Result Logs
(no jobs reported) ⏳ pending

Coverage Overview

  • Coverage history entries: 1

Coverage Trend

Metric Value
Current 77.97%
Baseline 0.00%
Delta +77.97%
Minimum 70.00%
Status ✅ Pass

Updated automatically; will refresh on subsequent CI/Docker completions.


Keepalive checklist

Scope

No scope information available

Tasks

  • No tasks defined

Acceptance criteria

  • No acceptance criteria defined

@github-actions
Copy link
Copy Markdown
Contributor

Keepalive loop status for PR #98

  • Action: wait (missing-agent-label)
  • Gate conclusion: success
  • Tasks: 0/0 complete
  • Iteration: 0/5
  • Keepalive enabled: no
  • Autofix enabled: no

stranske added a commit that referenced this pull request Dec 24, 2025
* chore(codex): bootstrap PR for issue #93

* Add metrics reporting to autofix loop (#97)

* Add keepalive metrics summary and artifact (#98)

* Add verifier workflow metrics emission

* Add weekly agent metrics aggregation

* docs: add agents-weekly-metrics.yml to workflow inventory and docs

- Add to EXPECTED_NAMES in test_workflow_naming.py
- Add to WORKFLOWS.md workflow catalog
- Add to WORKFLOW_SYSTEM.md workflow table
- Fix executable bit on aggregate_agent_metrics.py

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
stranske added a commit that referenced this pull request Dec 25, 2025
Cherry-picked from PR #100. Counts acceptance criteria checkboxes in
the PR body and linked issues, outputting acceptance_count for use
in verifier metrics.

This was the unique remaining value from PR #100 - the rest of its
changes (PRs #97, #98) were already merged.

Closes #100
stranske added a commit that referenced this pull request Dec 25, 2025
* feat(verifier): add acceptance_count output for metrics

Cherry-picked from PR #100. Counts acceptance criteria checkboxes in
the PR body and linked issues, outputting acceptance_count for use
in verifier metrics.

This was the unique remaining value from PR #100 - the rest of its
changes (PRs #97, #98) were already merged.

Closes #100

* Update .github/scripts/agents_verifier_context.js

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants