fix: include all optional extras in dependency refresh workflow#885
fix: include all optional extras in dependency refresh workflow#885
Conversation
Problem: - Maint 51 Dependency Refresh workflow only compiled requirements.lock with --extra dev - Missing langchain optional dependencies caused test_all_pyproject_dependencies_are_in_lock to fail - DEPENDENCY_TESTING.md had outdated examples from a different repo (app, llm, notebooks extras) Solution: - Update maint-51-dependency-refresh.yml to include both --extra dev and --extra langchain - Update verification step to match the compile command - Correct DEPENDENCY_TESTING.md to reflect actual extras in this repo (dev, langchain) - Update templates/dependency-refresh.yml template - Regenerate requirements.lock with all extras Verification: - test_all_pyproject_dependencies_are_in_lock now passes - requirements.lock header shows correct compile command Resolves: Issue raised in PR #884 by Codex bot Related: DEPENDENCY_TESTING.md documentation
Automated Status SummaryHead SHA: fde6a8f
Coverage Overview
Coverage Trend
Top Coverage Hotspots (lowest coverage)
Updated automatically; will refresh on subsequent CI/Docker completions. Keepalive checklistScopeAfter merging PR #103 (multi-agent routing infrastructure), we need to:
Context for AgentDesign Decisions & Constraints
Related Issues/PRsReferencesBlockers & Dependencies
TasksPipeline Validation
GITHUB_STEP_SUMMARY
Conditional Status Summary
Comment Pattern Cleanup
Acceptance criteria
|
🤖 Keepalive Loop StatusPR #885 | Agent: Codex | Iteration 0/5 Current State
🔍 Failure Classification| Error type | infrastructure | |
There was a problem hiding this comment.
Pull request overview
This PR fixes a sustainability issue in the dependency refresh workflow that was only compiling the lock file with the dev extra, missing the langchain optional dependencies. This caused test failures and required manual intervention.
Changes:
- Updated the dependency refresh workflow to include both
--extra devand--extra langchainflags - Corrected documentation to reflect the actual extras in this repo (
dev,langchain) instead of incorrect examples from another repo - Regenerated
requirements.lockwith all extras included
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/maint-51-dependency-refresh.yml |
Added --extra langchain to the compile command and verification step to ensure all optional dependencies are included |
templates/dependency-refresh.yml |
Updated template for consumer repos to include the langchain extra |
DEPENDENCY_TESTING.md |
Corrected documentation examples to reflect actual extras in this repo instead of outdated examples from a different repo |
requirements.lock |
Regenerated lock file with updated dependencies and corrected header comment showing the proper compile command |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Automated Status Summary
Scope
After merging PR #103 (multi-agent routing infrastructure), we need to:
GITHUB_STEP_SUMMARYoutput so iteration results are visible in the Actions UIContext for Agent
Design Decisions & Constraints
<!-- keepalive-loop-summary -->| github-actions[bot] | NEW: CLI agent iteration tracking | ✅ Keep for CLI agents |<!-- keepalive-state:v1 -->| agents-workflows-bot[bot] | State tracking |<!-- keepalive-round: N -->| stranske | OLD: Instruction comment | ❌ CLI agents dont need this |agent:*label), we should have exactly one updating comment (<!-- keepalive-loop-summary -->) instead of accumulating 10+ comments per PR.Related Issues/PRs
References
Blockers & Dependencies
Tasks
Pipeline Validation
agent:codexlabelGITHUB_STEP_SUMMARY
agents-keepalive-loop.ymlafter agent runConditional Status Summary
buildStatusBlock()inagents_pr_meta_update_body.jsto acceptagentTypeparameteragentTypeis set (CLI agent): hide workflow table, hide head SHA/required checksComment Pattern Cleanup
agent:*label):<!-- gate-summary: -->comment posting (use step summary instead)<!-- keepalive-round: N -->instruction comments (task appendix replaces this)<!-- keepalive-loop-summary -->to be the single source of truthagent:*label):<!-- gate-summary: -->commentagent_typeoutput to detect job so downstream workflows know the modeagents-pr-meta.ymlto conditionally skip gate summary for CLI agent PRsAcceptance criteria
Head SHA: 465a5d0
Latest Runs: ✅ success — Gate
Required: gate: ✅ success