-
Notifications
You must be signed in to change notification settings - Fork 1
fix: preserve code blocks in PR status summary without treating them as tasks #855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9598298
fix: Prevent task decomposer from splitting compound words on unspace…
stranske 2f4ab62
chore(autofix): formatting/lint
github-actions[bot] 00e5b75
fix: Strip code blocks before parsing tasks in issue_scope_parser
stranske a62c1cc
fix: preserve code blocks in PR status summary without adding checkboxes
stranske dfd66e8
fix: apply same slash fix to _is_multi_action_task in capability_chec…
stranske File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -311,3 +311,22 @@ def test_extract_json_payload_with_wrapped_text() -> None: | |
| def test_formatted_output_validates_sections() -> None: | ||
| assert issue_optimizer._formatted_output_valid("## Tasks\n- x\n## Acceptance Criteria\n- y") | ||
| assert not issue_optimizer._formatted_output_valid("## Tasks only") | ||
|
|
||
|
|
||
| def test_is_large_task_ignores_compound_slashes() -> None: | ||
| """_is_large_task should NOT flag compound words with unspaced slashes.""" | ||
| # Compound words should NOT be flagged as large | ||
| assert not issue_optimizer._is_large_task("Color-coded additions/removals") | ||
| assert not issue_optimizer._is_large_task("Update src/utils module") | ||
|
|
||
|
||
| # But spaced slashes still indicate alternatives (large task) | ||
| assert issue_optimizer._is_large_task("Option A / Option B") | ||
| assert issue_optimizer._is_large_task("Run lint / format / typecheck") | ||
|
|
||
|
|
||
| def test_is_large_task_detects_other_separators() -> None: | ||
| """_is_large_task should still detect other multi-action patterns.""" | ||
| assert issue_optimizer._is_large_task("Update docs and add tests") | ||
| assert issue_optimizer._is_large_task("Lint, format, typecheck") | ||
| assert issue_optimizer._is_large_task("Fix bug; write tests") | ||
| assert issue_optimizer._is_large_task("Run A + B") | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The capability_check.py module contains a similar function
_is_multi_action_task(line 180) that also checks for"/" in task. This will have the same issue as the functions fixed in this PR - it will incorrectly flag compound words like "additions/removals" and paths like "src/utils" as multi-action tasks. Consider updating that function to check for" / " in taskinstead for consistency with this fix.