Skip to content

fix: use lowercase variable names in function (N806)#830

Merged
stranske merged 1 commit intomainfrom
fix-n806-naming-violation
Jan 12, 2026
Merged

fix: use lowercase variable names in function (N806)#830
stranske merged 1 commit intomainfrom
fix-n806-naming-violation

Conversation

@stranske
Copy link
Copy Markdown
Owner

@stranske stranske commented Jan 12, 2026 •
edited by agents-workflows-bot bot
Loading

Source: Issue #167

Automated Status Summary

Scope

Address unmet acceptance criteria from PR #166.

Original scope:

  • The verifier CI query (verifier_ci_query.js) currently makes a single API call to fetch workflow run results. If the GitHub API returns a transient error (rate limit, timeout, network hiccup), the query fails silently and the verifier sees missing CI results.
  • This can cause false negatives where the verifier marks test-related criteria as NOT MET due to API failures rather than actual CI failures.
  • ### Current Behavior
  • - Single API call per workflow
  • - Failures logged as warnings but not retried
  • - Missing results treated as "not found"
  • ### Desired Behavior
  • - Retry transient failures with exponential backoff
  • - Distinguish between "CI not run" and "API error"
  • - Log retry attempts for debugging

Context for Agent

Related Issues/PRs

References

Tasks

  • Satisfy: Transient API failures (429, 500, 502, 503, 504) are retried up to 3 times
  • Satisfy: Successful retry results in correct CI data being returned
  • Satisfy: Max retry exceeded results in clear error message, not silent "not found"
  • Satisfy: Tests cover retry success and retry exhaustion scenarios
  • Satisfy: Selftest CI passes

Acceptance criteria

  • Transient API failures (429, 500, 502, 503, 504) are retried up to 3 times
  • Successful retry results in correct CI data being returned
  • Max retry exceeded results in clear error message, not silent "not found"
  • Tests cover retry success and retry exhaustion scenarios
  • Selftest CI passes

Head SHA: ae2926a
Latest Runs: ⏹️ cancelled — Gate
Required: gate: ⏹️ cancelled

Workflow / Job Result Logs
Agents Auto-Pilot ⏭️ skipped View run
Agents Bot Comment Handler ⏹️ cancelled View run
Agents Keepalive Loop ⏹️ cancelled View run
Agents PR meta manager ❔ in progress View run
Agents Verifier ✅ success View run
Auto-label Dependabot PRs ⏭️ skipped View run
CI Autofix Loop ⏹️ cancelled View run
Copilot code review ❔ in progress View run
Create Issue from Verification (DEPRECATED) ⏭️ skipped View run
Create Issue from Verification (Enhanced) ⏭️ skipped View run
Gate ⏹️ cancelled View run
Health 40 Sweep ✅ success View run
Health 44 Gate Branch Protection ✅ success View run
Health 45 Agents Guard ⏹️ cancelled View run
Health 50 Security Scan ✅ success View run
Maint 52 Validate Workflows ✅ success View run
PR 11 - Minimal invariant CI ✅ success View run
Selftest CI ✅ success View run

@stranske
fix: use lowercase variable names in function (N806)
ae2926a 
Variables GITHUB_MODELS_BASE_URL and GITHUB_DEFAULT_MODEL violated N806
naming convention. The sync workflow only validates E,W,F,I,B but consumer
repos run full lint including naming checks, causing sync PRs to fail CI.

Fixes sync PRs:
- Template #167
- Travel-Plan-Permission #379
Copilot AI review requested due to automatic review settings January 12, 2026 03:55
@stranske stranske added bug Something isn't working sync labels Jan 12, 2026
@stranske stranske enabled auto-merge (squash) January 12, 2026 03:55
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 12, 2026 •
edited
Loading

Automated Status Summary

Head SHA: b1c399c
Latest Runs: ⏳ pending — Gate
Required contexts: Gate / gate, Health 45 Agents Guard / Enforce agents workflow protections
Required: core tests (3.11): ⏳ pending, core tests (3.12): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job Result Logs
(no jobs reported) ⏳ pending —

Coverage Overview

  • Coverage history entries: 1

Coverage Trend

Metric Value
Current 92.21%
Baseline 85.00%
Delta +7.21%
Minimum 70.00%
Status ✅ Pass

Top Coverage Hotspots (lowest coverage)

File Coverage Missing
scripts/workflow_health_check.py 62.6% 28
scripts/classify_test_failures.py 62.9% 37
scripts/ledger_validate.py 65.3% 63
scripts/mypy_return_autofix.py 82.6% 11
scripts/ledger_migrate_base.py 85.5% 13
scripts/fix_cosmetic_aggregate.py 92.3% 1
scripts/coverage_history_append.py 92.8% 2
scripts/workflow_validator.py 93.3% 4
scripts/update_autofix_expectations.py 93.9% 1
scripts/pr_metrics_tracker.py 95.7% 3
scripts/generate_residual_trend.py 96.6% 1
scripts/build_autofix_pr_comment.py 97.0% 2
scripts/aggregate_agent_metrics.py 97.2% 0
scripts/fix_numpy_asserts.py 98.1% 0
scripts/sync_test_dependencies.py 98.3% 1

Updated automatically; will refresh on subsequent CI/Docker completions.

Keepalive checklist

Scope

No scope information available

Tasks

  • No tasks defined

Acceptance criteria

  • No acceptance criteria defined

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 12, 2026 •
edited
Loading

🤖 Keepalive Loop Status

PR #830 | Agent: Codex | Iteration 0/5

Current State

Metric Value
Iteration progress [----------] 0/5
Action wait (missing-agent-label)
Disposition skipped (transient)
Gate success
Tasks 0/10 complete
Timeout 45 min (default)
Timeout usage 2m elapsed (5%, 43m remaining)
Keepalive ❌ disabled
Autofix ❌ disabled

🔍 Failure Classification

| Error type | infrastructure |
| Error category | resource |
| Suggested recovery | Confirm the referenced resource exists (repo, PR, branch, workflow, or file). |

@stranske stranske merged commit 2e45feb into main Jan 12, 2026
146 of 150 checks passed
@stranske stranske deleted the fix-n806-naming-violation branch January 12, 2026 03:57
Copilot AI reviewed Jan 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes N806 lint errors that were causing sync failures in consumer repos. The variables GITHUB_MODELS_BASE_URL and GITHUB_DEFAULT_MODEL were incorrectly named in uppercase within the _get_llm_client() function, violating PEP 8 naming conventions for local variables.

Changes:

  • Renamed function-local variables from uppercase to lowercase to comply with N806 naming convention
  • Updated all references to the renamed variables within the function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 12, 2026

🤖 Auto-pilot: Issue closed but couldn't find linked merged PR.

Adding verify:evaluate label to issue for tracking.

@github-actions github-actions bot added the verify:evaluate Request LLM evaluation of merged PR label Jan 12, 2026
stranske added a commit that referenced this pull request Jan 12, 2026
@stranske
chore: trigger sync after N806 fix (PR #830)
d40f1bb
@stranske stranske mentioned this pull request Jan 12, 2026
Merged
43 tasks
stranske added a commit that referenced this pull request Jan 12, 2026
@stranske
chore: trigger sync after N806 fix (PR #830) (#831)
5ef05ec
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 12, 2026

✅ Auto-Pilot Complete

This issue has been fully processed:

  • ✅ Issue formatted and optimized
  • ✅ Agent assigned and PR created
  • ✅ PR merged
  • ✅ Verification triggered

Thank you for using auto-pilot! 🚀

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 12, 2026

✅ Auto-Pilot Complete

This issue has been fully processed:

  • ✅ Issue formatted and optimized
  • ✅ Agent assigned and PR created
  • ✅ PR merged
  • ✅ Verification triggered

Thank you for using auto-pilot! 🚀

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 12, 2026

✅ Auto-Pilot Complete

This issue has been fully processed:

  • ✅ Issue formatted and optimized
  • ✅ Agent assigned and PR created
  • ✅ PR merged
  • ✅ Verification triggered

Thank you for using auto-pilot! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

bug Something isn't working sync verify:evaluate Request LLM evaluation of merged PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stranske