Skip to content

fix: use expression syntax for force_mode boolean#647

Merged
stranske merged 1 commit intomainfrom
fix/boolean-expression-syntax
Jan 7, 2026
Merged

fix: use expression syntax for force_mode boolean#647
stranske merged 1 commit intomainfrom
fix/boolean-expression-syntax

Conversation

@stranske
Copy link
Copy Markdown
Owner

@stranske stranske commented Jan 7, 2026

Source: Issue #646

Automated Status Summary

Scope

Problem

Consumer repos are experiencing startup_failure when issues are labeled with agent:codex because the template is using mode: 'invite' without force_mode, causing the reusable workflow to prevent automatic bootstrap PR creation.

Root Cause

The reusable-agents-issue-bridge.yml workflow has logic (line 257-268) that overrides the mode to 'invite' for issue events, unless force_mode: true is explicitly set. This was intended to wait for human intervention, but it breaks the desired automatic PR creation workflow.

Changes

Template file: templates/consumer-repo/.github/workflows/agents-issue-intake.yml

Context for Agent

Design Decisions & Constraints

    1. Workflow should automatically create a bootstrap PR
  • | Keepalive | ❌ disabled |

Related Issues/PRs

Blockers & Dependencies

  • After sync, verify in any consumer repo:

Tasks

  • - Change mode from 'invite' to 'create' in bridge job
  • - Add force_mode: true to override issue event defaults

Acceptance criteria

  • - Travel-Plan-Permission
  • - Trend_Model_Project
  • - Manager-Database
  • - trip-planner
  • - Template
  • - And others (~7 total repos)

Head SHA: fe77f1a
Latest Runs: ❔ in progress — Gate
Required: gate: ❔ in progress

Workflow / Job Result Logs
Agents PR meta manager ❔ in progress View run
Auto-label Dependabot PRs ⏭️ skipped View run
CI Autofix Loop ✅ success View run
Copilot code review ❔ in progress View run
Gate ❔ in progress View run
Health 40 Sweep ✅ success View run
Health 44 Gate Branch Protection ✅ success View run
Health 45 Agents Guard ✅ success View run
Health 50 Security Scan ✅ success View run
Maint 52 Validate Workflows ✅ success View run
PR 11 - Minimal invariant CI ✅ success View run
Selftest CI ✅ success View run
Validate Sync Manifest ✅ success View run

GitHub Actions workflow_call requires boolean inputs to use expression
syntax ${{ true }} rather than bare true when calling reusable workflows.

This fixes the startup_failure occurring in all consumer repos after the
previous template sync.
Copilot AI review requested due to automatic review settings January 7, 2026 18:51
@stranske stranske enabled auto-merge (squash) January 7, 2026 18:51
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 7, 2026

Automated Status Summary

Head SHA: fa55d03
Latest Runs: ⏳ pending — Gate
Required contexts: Gate / gate, Health 45 Agents Guard / Enforce agents workflow protections
Required: core tests (3.11): ⏳ pending, core tests (3.12): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job Result Logs
(no jobs reported) ⏳ pending

Coverage Overview

  • Coverage history entries: 1

Coverage Trend

Metric Value
Current 92.21%
Baseline 85.00%
Delta +7.21%
Minimum 70.00%
Status ✅ Pass

Top Coverage Hotspots (lowest coverage)

File Coverage Missing
scripts/workflow_health_check.py 62.6% 28
scripts/classify_test_failures.py 62.9% 37
scripts/ledger_validate.py 65.3% 63
scripts/mypy_return_autofix.py 82.6% 11
scripts/ledger_migrate_base.py 85.5% 13
scripts/fix_cosmetic_aggregate.py 92.3% 1
scripts/coverage_history_append.py 92.8% 2
scripts/workflow_validator.py 93.3% 4
scripts/update_autofix_expectations.py 93.9% 1
scripts/pr_metrics_tracker.py 95.7% 3
scripts/generate_residual_trend.py 96.6% 1
scripts/build_autofix_pr_comment.py 97.0% 2
scripts/aggregate_agent_metrics.py 97.2% 0
scripts/fix_numpy_asserts.py 98.1% 0
scripts/sync_test_dependencies.py 98.3% 1

Updated automatically; will refresh on subsequent CI/Docker completions.


Keepalive checklist

Scope

No scope information available

Tasks

  • No tasks defined

Acceptance criteria

  • No acceptance criteria defined

@stranske stranske merged commit a505c16 into main Jan 7, 2026
91 checks passed
@stranske stranske deleted the fix/boolean-expression-syntax branch January 7, 2026 18:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a critical startup_failure issue in consumer repos by correcting the syntax for passing a boolean value to a reusable workflow. After PR #646 introduced force_mode: true, all consumer repos experienced failures because GitHub Actions requires boolean inputs to reusable workflows to use expression syntax ${{ true }} rather than bare true (which is treated as a string).

Key Changes

  • Updated force_mode parameter from bare true to expression syntax ${{ true }}
  • Reordered force_mode to appear after post_agent_comment (cosmetic change with no functional impact)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants