feat: Enable LLM for agents:apply-suggestions by default - #639
Conversation
When a user adds agents:apply-suggestions label, they explicitly want the LLM suggestions applied. The previous use_llm=False only did basic reformatting without populating sections with analyzed content. Changes: - apply_suggestions now uses use_llm=True by default - Will populate Tasks with suggested splits from analysis - Will extract Why/Scope/Non-Goals from context - Will add objective acceptance criteria from suggestions Expected impact: Quality score 6/10 → 8.5/10 Rationale: Label addition is explicit user consent to apply LLM-generated suggestions. No reason to use non-LLM mode when user requests application.
Automated Status SummaryHead SHA: d002e2c
Coverage Overview
Coverage Trend
Top Coverage Hotspots (lowest coverage)
Updated automatically; will refresh on subsequent CI/Docker completions. Keepalive checklistScopeNo scope information available Tasks
Acceptance criteria
|
🤖 Keepalive Loop StatusPR #639 | Agent: Codex | Iteration 0/5 Current State
🔍 Failure Classification| Error type | infrastructure | |
There was a problem hiding this comment.
Pull request overview
This PR enables LLM-powered content population for the agents:apply-suggestions workflow phase by removing an explicit override that was preventing the apply_suggestions function from using its default LLM behavior. The change aims to improve the quality of applied suggestions from 6/10 to ~8.5/10 by intelligently populating issue template sections rather than just creating empty structure.
Key Changes:
- Removed
use_llm=Falseoverride in the workflow, allowingapply_suggestionsto use its defaultuse_llm=Truebehavior - Updated documentation to reflect testing results, expected quality improvements, and deployment status
- Added detailed test results documentation showing substantive quality assessments
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| templates/consumer-repo/.github/workflows/agents-issue-optimizer.yml | Removed explicit use_llm=False override to enable intelligent section population with LLM |
| docs/plans/langchain-post-code-rollout.md | Documented testing results, quality improvements, and deployment status for the LLM-enabled apply-suggestions workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - **Gap:** Doesn't populate missing sections; could add task priority ordering | ||
| - **Workflow:** `agents-issue-optimizer.yml` Phase 1 (analyze) | ||
|
|
||
| 2. **issue_formatter.py** (apply_suggestions) - Intelligent content extraction |
There was a problem hiding this comment.
The documentation incorrectly attributes the apply_suggestions function to issue_formatter.py. The apply_suggestions function is actually defined in issue_optimizer.py (line 677). This section should reference issue_optimizer.py instead of issue_formatter.py.
| 2. **issue_formatter.py** (apply_suggestions) - Intelligent content extraction | |
| 2. **issue_optimizer.py** (`apply_suggestions`) - Intelligent content extraction |
| - **Test:** Manager-Database #184 (same issue) | ||
| - **Quality Score: 6/10 (with use_llm=False)** → **Expected 8.5/10 (with use_llm=True)** | ||
| - **Strengths:** Consistent structure; preserves original content | ||
| - **Change:** Now uses `use_llm=True` by default - will populate sections with analyzed content |
There was a problem hiding this comment.
The statement "Now uses use_llm=True by default" is misleading. The apply_suggestions function in issue_optimizer.py already has use_llm=True as its default parameter value (line 678). This change is actually removing the explicit override of use_llm=False in the workflow, allowing it to use the function's default behavior. Consider rephrasing to "Now uses function default (use_llm=True)" or "Removed explicit override, now uses default LLM behavior".
| - **Change:** Now uses `use_llm=True` by default - will populate sections with analyzed content | |
| - **Change:** Removed explicit `use_llm=False` override; now uses function default (`use_llm=True`) - will populate sections with analyzed content |
| 4. ~~**Live test `agents:apply-suggestions`**~~ ✅ Tested on Manager-Database #184 - Quality: 6/10 | ||
|
|
||
| ### High Priority Enhancements | ||
| 1. ~~**Enable LLM for apply_suggestions**~~ ✅ Changed `use_llm=False` to `use_llm=True` in workflow |
There was a problem hiding this comment.
The statement "Now uses use_llm=True by default" is misleading in this context. The apply_suggestions function already defaults to use_llm=True in its signature. This change is removing an explicit override (use_llm=False) that was preventing the function from using its default LLM behavior. Consider rephrasing for clarity.
| 1. ~~**Enable LLM for apply_suggestions**~~ ✅ Changed `use_llm=False` to `use_llm=True` in workflow | |
| 1. ~~**Allow apply_suggestions to use default LLM behavior**~~ ✅ Removed explicit `use_llm=False` override so workflow uses `apply_suggestions`'s default `use_llm=True` |
Automated Status Summary
Scope
Address unmet acceptance criteria from PR #183.
Original scope:
Context for Agent
Related Issues/PRs
References
Tasks
Acceptance criteria
Head SHA: 3bf71f7
Latest Runs: ✅ success — Gate
Required: gate: ✅ success