Skip to content

Fix: Add --repo flag to gh commands in issue optimizer - #637

Merged
stranske merged 1 commit into
mainfrom
fix/gh-repo-flag
Jan 7, 2026
Merged

Fix: Add --repo flag to gh commands in issue optimizer#637
stranske merged 1 commit into
mainfrom
fix/gh-repo-flag

Conversation

@stranske

@stranske stranske commented Jan 7, 2026

Copy link
Copy Markdown
Owner

Source: Issue #184

Automated Status Summary

Scope

Address unmet acceptance criteria from PR #183.

Original scope:

  • Scope section missing from source issue.

Context for Agent

Related Issues/PRs

References

Tasks

  • Tasks section missing from source issue.

Acceptance criteria

  • Acceptance criteria section missing from source issue.

Head SHA: 0e12379
Latest Runs: ✅ success — Gate
Required: gate: ✅ success

Workflow / Job Result Logs
Agents PR meta manager ❔ in progress View run
Auto-label Dependabot PRs ⏭️ skipped View run
CI Autofix Loop ✅ success View run
Copilot code review ✅ success View run
Gate ✅ success View run
Health 40 Sweep ✅ success View run
Health 44 Gate Branch Protection ✅ success View run
Health 45 Agents Guard ✅ success View run
Health 50 Security Scan ✅ success View run
Maint 52 Validate Workflows ✅ success View run
PR 11 - Minimal invariant CI ✅ success View run
Selftest CI ✅ success View run
Validate Sync Manifest ✅ success View run

When the workflow checks out the Workflows repo, the working directory
context changes. The gh CLI needs explicit --repo flag to target the
consumer repo when posting comments or editing issues.

Without this, gh CLI tries to operate on stranske/Workflows instead
of the consumer repo, causing 'Resource not accessible by integration'
errors.
Copilot AI review requested due to automatic review settings January 7, 2026 12:01
@github-actions

github-actions Bot commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

Automated Status Summary

Head SHA: e26c227
Latest Runs: ⏳ pending — Gate
Required contexts: Gate / gate, Health 45 Agents Guard / Enforce agents workflow protections
Required: core tests (3.11): ⏳ pending, core tests (3.12): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job Result Logs
(no jobs reported) ⏳ pending

Coverage Overview

  • Coverage history entries: 1

Coverage Trend

Metric Value
Current 92.21%
Baseline 85.00%
Delta +7.21%
Minimum 70.00%
Status ✅ Pass

Top Coverage Hotspots (lowest coverage)

File Coverage Missing
scripts/workflow_health_check.py 62.6% 28
scripts/classify_test_failures.py 62.9% 37
scripts/ledger_validate.py 65.3% 63
scripts/mypy_return_autofix.py 82.6% 11
scripts/ledger_migrate_base.py 85.5% 13
scripts/fix_cosmetic_aggregate.py 92.3% 1
scripts/coverage_history_append.py 92.8% 2
scripts/workflow_validator.py 93.3% 4
scripts/update_autofix_expectations.py 93.9% 1
scripts/pr_metrics_tracker.py 95.7% 3
scripts/generate_residual_trend.py 96.6% 1
scripts/build_autofix_pr_comment.py 97.0% 2
scripts/aggregate_agent_metrics.py 97.2% 0
scripts/fix_numpy_asserts.py 98.1% 0
scripts/sync_test_dependencies.py 98.3% 1

Updated automatically; will refresh on subsequent CI/Docker completions.


Keepalive checklist

Scope

No scope information available

Tasks

  • No tasks defined

Acceptance criteria

  • No acceptance criteria defined

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a critical bug where the agents:optimize workflow was unable to interact with consumer repository issues after checking out the stranske/Workflows repository. The fix adds explicit --repo flags to all gh issue commands to ensure they target the correct repository.

Key Changes:

  • Added --repo "${{ github.repository }}" flag to all gh issue comment and gh issue edit commands
  • Introduced a REPO environment variable in the label management step for consistency
  • Updated 9 command invocations across 4 workflow phases (analyze, dedup check, apply, format, and label management)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +314 to +326
gh issue edit "${ISSUE_NUMBER}" --repo "${REPO}" \
--remove-label "agents:optimize" || true
gh issue edit "${ISSUE_NUMBER}" --repo "${REPO}" \
--remove-label "agents:apply-suggestions"
gh issue edit "${ISSUE_NUMBER}" --repo "${REPO}" \
--add-label "agents:formatted"
echo "Labels updated: removed optimize/apply-suggestions, added formatted"
elif [[ "$PHASE" == "format" ]]; then
# Remove format trigger label and add formatted result label
gh issue edit "${ISSUE_NUMBER}" --remove-label "agents:format"
gh issue edit "${ISSUE_NUMBER}" --add-label "agents:formatted"
gh issue edit "${ISSUE_NUMBER}" --repo "${REPO}" \
--remove-label "agents:format"
gh issue edit "${ISSUE_NUMBER}" --repo "${REPO}" \
--add-label "agents:formatted"

Copilot AI Jan 7, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent quoting style for the --repo flag. Lines 141, 202, 260, and 300 use double quotes with GitHub Actions expression syntax "${{ github.repository }}", while lines 314-326 use double quotes with shell variable expansion "${REPO}". While both approaches work, it's better to use the same pattern throughout for consistency. Consider using "${{ github.repository }}" directly in all locations, or consistently use the environment variable approach everywhere.

Copilot uses AI. Check for mistakes.
@github-actions

github-actions Bot commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

🤖 Keepalive Loop Status

PR #637 | Agent: Codex | Iteration 0/5

Current State

Metric Value
Iteration progress [----------] 0/5
Action wait (missing-agent-label)
Disposition skipped (transient)
Gate success
Tasks 0/2 complete
Keepalive ❌ disabled
Autofix ❌ disabled

🔍 Failure Classification

| Error type | infrastructure |
| Error category | resource |
| Suggested recovery | Confirm the referenced resource exists (repo, PR, branch, workflow, or file). |

@stranske
stranske merged commit bdee64f into main Jan 7, 2026
177 checks passed
@stranske
stranske deleted the fix/gh-repo-flag branch January 7, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants