Skip to content

fix: Add PYTHONPATH to issue optimizer analyze steps #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stranske merged 1 commit into from
Jan 7, 2026
Merged

fix: Add PYTHONPATH to issue optimizer analyze steps #635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions templates/consumer-repo/.github/workflows/agents-issue-optimizer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ jobs:
ISSUE_NUMBER: ${{ steps.check.outputs.issue_number }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
PYTHONPATH: ${{ github.workspace }}
run: |
echo "Running analysis on issue #${ISSUE_NUMBER}"
python scripts/langchain/issue_optimizer.py \
Expand Down Expand Up @@ -138,7 +139,8 @@ jobs:
# Post comment
gh issue comment "${ISSUE_NUMBER}" --body-file /tmp/comment.md

echo "Analysis complete. Review suggestions and add 'agents:apply-suggestions' label to apply."
echo "Analysis complete. Review suggestions and add"
echo "'agents:apply-suggestions' label to apply."

- name: Advisory issue dedup check
if: steps.check.outputs.should_run == 'true' && steps.check.outputs.phase == 'analyze'
Expand All @@ -147,10 +149,15 @@ jobs:
ISSUE_NUMBER: ${{ steps.check.outputs.issue_number }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
PYTHONPATH: ${{ github.workspace }}
run: |
echo "Checking for potential duplicate issues (advisory)"
gh api "repos/${{ github.repository }}/issues?state=open&per_page=100" --paginate > /tmp/open_issues.json
gh api "repos/${{ github.repository }}/issues/${ISSUE_NUMBER}/comments" --paginate > /tmp/dedup_comments.json
gh api \
"repos/${{ github.repository }}/issues?state=open&per_page=100" \
--paginate > /tmp/open_issues.json
gh api \
"repos/${{ github.repository }}/issues/${ISSUE_NUMBER}/comments" \
--paginate > /tmp/dedup_comments.json

python - <<'PY' || true
import json
Expand Down Expand Up @@ -201,10 +208,12 @@ jobs:
ISSUE_NUMBER: ${{ steps.check.outputs.issue_number }}
GH_TOKEN: ${{ github.token }}
run: |
echo "Extracting suggestions from comments on issue #${ISSUE_NUMBER}"
echo \"Extracting suggestions from comments on issue #${ISSUE_NUMBER}\"

Copilot AI Jan 7, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quotes are unnecessarily escaped here. In YAML multi-line shell scripts (using run: |), quotes do not need to be escaped with backslashes. This should be echo "Extracting suggestions from comments on issue #${ISSUE_NUMBER}" to match the pattern used throughout the rest of the file (e.g., line 106: echo "Running analysis on issue #${ISSUE_NUMBER}").

Suggested change
echo \"Extracting suggestions from comments on issue #${ISSUE_NUMBER}\"
echo "Extracting suggestions from comments on issue #${ISSUE_NUMBER}"

Copilot uses AI. Check for mistakes.

# Get all comments and find the one with suggestions JSON
gh api "repos/${{ github.repository }}/issues/${ISSUE_NUMBER}/comments" --paginate > /tmp/comments.json
gh api \
\"repos/${{ github.repository }}/issues/${ISSUE_NUMBER}/comments\" \
Comment on lines +214 to +215

Copilot AI Jan 7, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quotes are unnecessarily escaped here. In YAML multi-line shell scripts (using run: |), quotes do not need to be escaped with backslashes. This should be "repos/${{ github.repository }}/issues/${ISSUE_NUMBER}/comments" to match the pattern used throughout the rest of the file (e.g., line 93: gh api "repos/${{ github.repository }}/issues/${ISSUE_NUMBER}" > /tmp/issue.json).

Copilot uses AI. Check for mistakes.
--paginate > /tmp/comments.json

# Extract suggestions JSON from comment
python -c "
Expand Down
Loading