-
Notifications
You must be signed in to change notification settings - Fork 1
Docs/langchain issue intake proposal #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
423bd18
docs: add LangChain issue intake enhancement proposal
stranske bcc57f7
fix: add PyPI version verification to prevent shipping outdated deps
stranske 30dca19
docs: expand semantic dedup section in LangChain proposal
stranske 0ca1ca4
docs: expand semantic matching to cover both issues AND labels
stranske cfd91ab
fix: resolve merge conflict in langchain proposal - keep expanded sem…
stranske 50305db
fix: address PR review feedback from bot comments
stranske dc56436
fix: add maint-auto-update-pypi-versions.yml to workflow inventory
stranske File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,125 @@ | ||
| # Auto-update dev tool versions from PyPI | ||
| # | ||
| # This workflow ensures autofix-versions.env stays current with PyPI releases. | ||
| # It runs daily and creates a PR if any versions are outdated. | ||
| # | ||
| # CRITICAL: This workflow MUST run before maint-52-sync-dev-versions.yml | ||
| # to ensure we never ship stale versions to consumer repos. | ||
|
|
||
| name: Maint Auto-Update PyPI Versions | ||
|
|
||
| on: | ||
| schedule: | ||
| # Daily at 03:00 UTC (before the weekly sync at 05:00) | ||
| - cron: '0 3 * * *' | ||
| workflow_dispatch: | ||
| inputs: | ||
| dry_run: | ||
| description: 'Preview changes without creating PR' | ||
| type: boolean | ||
| default: false | ||
|
|
||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
|
|
||
| jobs: | ||
| check-and-update: | ||
| name: Check PyPI for updates | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout Workflows | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 1 | ||
|
|
||
| - name: Setup Python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.12' | ||
|
|
||
| - name: Check for outdated versions | ||
| id: check | ||
| run: | | ||
| echo "🔍 Checking PyPI for latest versions..." | ||
| python scripts/update_versions_from_pypi.py --check 2>&1 | tee /tmp/check_output.txt | ||
| # Script exits 0 even for outdated (use --fail-on-outdated for non-zero) | ||
| # Check output directly for "outdated" to determine if updates are needed | ||
| if grep -q "outdated" /tmp/check_output.txt; then | ||
| echo "has_updates=true" >> "$GITHUB_OUTPUT" | ||
| else | ||
| echo "has_updates=false" >> "$GITHUB_OUTPUT" | ||
| fi | ||
| cat /tmp/check_output.txt | ||
|
|
||
| - name: Update versions | ||
| id: update | ||
| if: steps.check.outputs.has_updates == 'true' && inputs.dry_run != true | ||
| run: | | ||
| echo "📦 Updating autofix-versions.env with latest PyPI versions..." | ||
| python scripts/update_versions_from_pypi.py --apply 2>&1 | tee /tmp/update_output.txt | ||
|
|
||
| # Extract update summary for PR body | ||
| { | ||
| echo "summary<<EOF" | ||
| cat /tmp/update_output.txt | ||
| echo "EOF" | ||
| } >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Create PR | ||
| if: steps.check.outputs.has_updates == 'true' && inputs.dry_run != true | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| # Configure git | ||
| git config user.name "github-actions[bot]" | ||
| git config user.email "github-actions[bot]@users.noreply.github.com" | ||
|
|
||
| # Check if there are actual changes | ||
| if git diff --quiet .github/workflows/autofix-versions.env; then | ||
| echo "No changes to commit" | ||
| exit 0 | ||
| fi | ||
|
|
||
| # Create branch | ||
| branch="auto/update-pypi-versions-$(date +%Y%m%d)" | ||
| git checkout -b "$branch" | ||
|
|
||
| # Commit changes | ||
| git add .github/workflows/autofix-versions.env | ||
| git commit -m "chore: update dev tool versions from PyPI | ||
|
|
||
| Auto-generated by maint-auto-update-pypi-versions workflow. | ||
|
|
||
| ${{ steps.update.outputs.summary }}" | ||
|
|
||
| # Push and create PR | ||
| git push origin "$branch" | ||
|
|
||
| gh pr create \ | ||
| --title "chore: update dev tool versions from PyPI" \ | ||
| --body "## Summary | ||
|
|
||
| This PR updates the pinned dev tool versions in \`autofix-versions.env\` to match the latest releases on PyPI. | ||
|
|
||
| ### Changes | ||
| \`\`\` | ||
| ${{ steps.update.outputs.summary }} | ||
| \`\`\` | ||
|
|
||
| ### Why this matters | ||
| Keeping dev tool versions current ensures: | ||
| - Consumer repos receive the latest bug fixes and features | ||
| - We don't ship known-vulnerable or outdated tooling | ||
| - Version drift between repos is minimized | ||
|
|
||
| --- | ||
| *Auto-generated by the [maint-auto-update-pypi-versions](.github/workflows/maint-auto-update-pypi-versions.yml) workflow*" \ | ||
| --label "dependencies" \ | ||
| --label "automation" | ||
|
|
||
| - name: Dry run summary | ||
| if: inputs.dry_run == true | ||
| run: | | ||
| echo "🔍 Dry run - would have made these updates:" | ||
| python scripts/update_versions_from_pypi.py --check | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The git diff check uses '--quiet' flag which suppresses all output and only returns exit codes. However, the echo after it will always print "No changes to commit" even if there are changes, because git diff exits with 0 (no changes) or 1 (has changes). The condition should be 'if ! git diff --quiet' to properly detect when there ARE changes and only then exit early when there are NO changes.