Skip to content

fix(agents): recognize bare coderabbit login (orphan-branch sweep) #3404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stranske merged 4 commits into from
Sep 7, 2026
Merged

fix(agents): recognize bare coderabbit login (orphan-branch sweep) #3404

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
432a2b8
fix(agents): recognize bare coderabbit login
Sep 5, 2026
295edf8
test(agents): keep bot author defaults aligned
Sep 5, 2026
b5b2090
chore: sync consumer templates
github-actions[bot] Sep 7, 2026
0cca068
test(agents): protect both CodeRabbit identities and inherited defaults
Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/scripts/__tests__/bot-comment-handler.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ test('default bot author allowlist recognizes canonical review bots', () => {
'copilot-pull-request-reviewer',
'copilot-pull-request-reviewer[bot]',
'github-actions[bot]',
'coderabbitai',
'coderabbitai[bot]',
'chatgpt-codex-connector',
'chatgpt-codex-connector[bot]',
Expand Down
1 change: 1 addition & 0 deletions .github/scripts/bot-comment-handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ const DEFAULT_BOT_AUTHORS = Object.freeze([
'copilot-pull-request-reviewer',
'copilot-pull-request-reviewer[bot]',
'github-actions[bot]',
'coderabbitai',
Comment thread
stranske marked this conversation as resolved.
'coderabbitai[bot]',
Comment thread
stranske marked this conversation as resolved.
'chatgpt-codex-connector',
'chatgpt-codex-connector[bot]',
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/reusable-bot-comment-handler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ on:
default: >-
Copilot,copilot[bot],copilot-pull-request-reviewer,
copilot-pull-request-reviewer[bot],
github-actions[bot],coderabbitai[bot],
github-actions[bot],coderabbitai,coderabbitai[bot],
Comment thread
coderabbitai[bot] marked this conversation as resolved.
chatgpt-codex-connector,chatgpt-codex-connector[bot]
skip_if_human_replied:
description: 'Legacy option: skip active threads after any non-bot reply'
Expand Down Expand Up @@ -72,7 +72,7 @@ on:
default: >-
Copilot,copilot[bot],copilot-pull-request-reviewer,
copilot-pull-request-reviewer[bot],
github-actions[bot],coderabbitai[bot],
github-actions[bot],coderabbitai,coderabbitai[bot],
chatgpt-codex-connector,chatgpt-codex-connector[bot]
skip_if_human_replied:
description: 'Legacy option: skip active threads after any non-bot reply'
Expand Down
2 changes: 1 addition & 1 deletion docs/bot-comment-handler.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ By default, the workflow processes comments from:
- `copilot-pull-request-reviewer` - GitHub Copilot pull-request review
- `copilot-pull-request-reviewer[bot]` - GitHub Copilot reviewer bot variant
- `github-actions[bot]` - GitHub Actions (lint, type check suggestions)
- `coderabbitai[bot]` - CodeRabbit AI review
- `coderabbitai` and `coderabbitai[bot]` - CodeRabbit AI review identities
- `chatgpt-codex-connector` - Codex connector review
- `chatgpt-codex-connector[bot]` - Codex connector bot identity

Expand Down
1 change: 1 addition & 0 deletions templates/consumer-repo/.github/scripts/bot-comment-handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ const DEFAULT_BOT_AUTHORS = Object.freeze([
'copilot-pull-request-reviewer',
'copilot-pull-request-reviewer[bot]',
'github-actions[bot]',
'coderabbitai',
'coderabbitai[bot]',
'chatgpt-codex-connector',
'chatgpt-codex-connector[bot]',
Expand Down
4 changes: 4 additions & 0 deletions tests/workflows/test_bot_comment_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ def test_reusable_bot_comment_handler_ignores_agents_paths() -> None:
bot_authors = inputs.get("bot_authors", {}).get("default", "")
assert "copilot-pull-request-reviewer" in bot_authors
assert "copilot-pull-request-reviewer[bot]" in bot_authors
assert "coderabbitai" in bot_authors.split(",")
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
assert "chatgpt-codex-connector[bot]" in bot_authors


Expand Down Expand Up @@ -72,6 +73,9 @@ def test_reusable_bot_comment_handler_has_manual_terminal_probe() -> None:

assert dispatch_inputs["pr_number"].get("required") is True
assert dispatch_inputs["dry_run"].get("default") is True
assert dispatch_inputs["bot_authors"].get("default") == call_inputs["bot_authors"].get(
"default"
)
assert dispatch_inputs["ignored_paths"].get("default") == call_inputs["ignored_paths"].get(
"default"
)
Expand Down