Repository navigation
docs: align consumer multi-agent runner guide #3354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,6 +36,9 @@ def test_consumer_operator_docs_match_gate_followup_topology() -> None: | |
| root_labels = Path("docs/LABELS.md").read_text(encoding="utf-8") | ||
| labels = Path("templates/consumer-repo/docs/LABELS.md").read_text(encoding="utf-8") | ||
| setup = Path("templates/consumer-repo/docs/SETUP_CHECKLIST.md").read_text(encoding="utf-8") | ||
| gate_followups = Path( | ||
| "templates/consumer-repo/.github/workflows/agents-81-gate-followups.yml" | ||
| ).read_text(encoding="utf-8") | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
If the workflow is re-scoped in AGENTS.md reference: AGENTS.md:L29-L35 Useful? React with 👍 / 👎.
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Addressed on exact head 6046661. Both the guide and workflow are now selected from compile_manifest output by their delivery targets. Parsed YAML must contain run-cursor and run-gemini with exact uses values and matching needs.evaluate.outputs.agent_type conditions, so stale template text or an unrelated leftover marker no longer passes. Validation: focused/template/manifest suite 55 passed with one credential-gated skip; template sync and strict completeness passed; drift check reports zero unallowlisted drift; Ruff, Black, and diff-check passed. |
||
|
|
||
| assert "Root/non-consolidated: sets `force_retry=true`" in root_labels | ||
| assert ".github/workflows/agents-keepalive-loop.yml" in root_labels | ||
|
|
@@ -45,8 +48,10 @@ def test_consumer_operator_docs_match_gate_followup_topology() -> None: | |
| ): | ||
| assert retired_surface not in labels | ||
|
|
||
| assert "no Cursor runner job" in labels | ||
| assert "no Gemini runner job" in labels | ||
| for agent, display_name in (("cursor", "Cursor"), ("gemini", "Gemini")): | ||
| assert f"reusable-{agent}-run.yml@main" in gate_followups | ||
| assert f"Routes consumer Gate-followup keepalive to the {display_name} runner" in labels | ||
| assert f"dispatches `reusable-{agent}-run.yml`" in labels | ||
|
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Addressed on exact head 6046661. The contract now resolves the delivered workflow and label guide through the compiled sync manifest, parses the workflow YAML, and asserts the run-cursor/run-gemini job IDs, their exact reusable workflow targets, each matching agent_type condition, and the matching detailed guide job IDs.
coderabbitai[bot] marked this conversation as resolved.
Outdated
|
||
| assert "applying the label does not trigger a retry by itself" in labels | ||
| assert "Does not set `force_retry`" in labels | ||
| assert "agents-keepalive-loop.yml" not in labels | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.