Skip to content

Fix misleading comment in formatSimpleFollowUpIssue#319

Merged
stranske merged 7 commits intomainfrom
copilot/sub-pr-316-another-one
Dec 30, 2025
Merged

Fix misleading comment in formatSimpleFollowUpIssue#319
stranske merged 7 commits intomainfrom
copilot/sub-pr-316-another-one

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Dec 30, 2025

Automated Status Summary

Scope

  • Scope section missing from source issue.

Tasks

  • Tasks section missing from source issue.

Acceptance criteria

  • Acceptance criteria section missing from source issue.
  • Head SHA: 9334b84
  • Latest Runs: ❔ in progress — Gate
  • Required: gate: ❔ in progress
  • | Workflow / Job | Result | Logs |
  • |----------------|--------|------|
  • | Agents PR meta manager | ❔ in progress | View run |
  • | CI Autofix Loop | ✅ success | View run |
  • | Copilot code review | ❔ in progress | View run |
  • | Gate | ❔ in progress | View run |
  • | Health 40 Sweep | ✅ success | View run |
  • | Health 44 Gate Branch Protection | ✅ success | View run |
  • | Health 45 Agents Guard | ✅ success | View run |
  • | Health 50 Security Scan | ❔ in progress | View run |
  • | Maint 52 Validate Workflows | ✅ success | View run |
  • | PR 11 - Minimal invariant CI | ✅ success | View run |
  • | Selftest CI | ✅ success | View run |
  • | Validate Sync Manifest | ✅ success | View run |
  • Head SHA: c5f36b5
  • Latest Runs: ❔ in progress — Gate
  • Required: gate: ❔ in progress
  • | Workflow / Job | Result | Logs |
  • |----------------|--------|------|
  • | Agents PR meta manager | ❔ in progress | View run |
  • | CI Autofix Loop | ✅ success | View run |
  • | Copilot code review | ❔ in progress | View run |
  • | Gate | ❔ in progress | View run |
  • | Health 40 Sweep | ✅ success | View run |
  • | Health 44 Gate Branch Protection | ✅ success | View run |
  • | Health 45 Agents Guard | ✅ success | View run |
  • | Health 50 Security Scan | ❔ in progress | View run |
  • | Maint 52 Validate Workflows | ✅ success | View run |
  • | PR 11 - Minimal invariant CI | ✅ success | View run |
  • | Selftest CI | ❔ in progress | View run |
  • | Validate Sync Manifest | ✅ success | View run |

Head SHA: c3c8d61
Latest Runs: ⏳ queued — Gate
Required: gate: ⏳ queued

Workflow / Job Result Logs
Agents PR meta manager ❔ in progress View run
CI Autofix Loop ✅ success View run
Gate ⏳ queued View run
Health 40 Sweep ✅ success View run
Health 44 Gate Branch Protection ❔ in progress View run
Health 45 Agents Guard ✅ success View run
Health 50 Security Scan ❔ in progress View run
Maint 52 Validate Workflows ❔ in progress View run
PR 11 - Minimal invariant CI ❔ in progress View run
Selftest CI ❔ in progress View run
Validate Sync Manifest ✅ success View run

stranske and others added 5 commits December 30, 2025 14:30
The documentation incorrectly stated that pytest-xdist was missing and
tests run sequentially. In fact:

- pytest-xdist is already in pyproject.toml (version 3.8.0)
- reusable-10-ci-python.yml installs pytest-xdist automatically
- The workflow uses '-n auto --dist=loadgroup' when xdist is detected

Updated the Performance section and Recommendations to reflect the
actual implemented state.
1. Add helper functions to detect placeholder and garbage content:
   - isPlaceholderContent(): Detects "section missing from source issue" text
   - looksLikeSectionHeader(): Filters markdown headers like "## Related"
   - looksLikeReferenceLink(): Filters PR/Issue reference links

2. Update extractUncheckedItems() to use the new filters, removing:
   - Placeholder text from bot-generated PR templates
   - Markdown section headers incorrectly captured as criteria
   - PR/Issue reference links that aren't actual acceptance criteria

3. Add hasSubstantiveContent flag to formatFollowUpIssue() return:
   - true when there are real tasks/criteria/gaps to address
   - false when all content is placeholders or empty

4. Update both verifier workflows to skip issue creation when
   hasSubstantiveContent is false

Fixes issues like #313 (contentless) and #306 (garbage content).

Tested:
- PR #304 scenario: Now correctly filters out "## Related" and "- PR #N"
- PR #310 scenario: Now returns hasSubstantiveContent=false
- All 39 existing tests pass
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Base automatically changed from fix/verifier-contentless-issues to main December 30, 2025 15:50
@stranske stranske marked this pull request as ready for review December 30, 2025 15:51
Copilot AI review requested due to automatic review settings December 30, 2025 15:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@agents-workflows-bot
Copy link
Copy Markdown
Contributor

⚠️ Action Required: Unable to determine source issue for PR #319. The PR title, branch name, or body must contain the issue number (e.g. #123, branch: issue-123, or the hidden marker ).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 30, 2025

Automated Status Summary

Head SHA: 8b4eb1e
Latest Runs: ⏳ pending — Gate
Required contexts: Gate / gate, Health 45 Agents Guard / Enforce agents workflow protections
Required: core tests (3.11): ⏳ pending, core tests (3.12): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job Result Logs
(no jobs reported) ⏳ pending

Coverage Overview

  • Coverage history entries: 1

Coverage Trend

Metric Value
Current 0.00%
Baseline 85.00%
Delta -85.00%
Minimum 70.00%
Status ❌ Below minimum

Top Coverage Hotspots (lowest coverage)

File Coverage Missing
src/trend_analysis/_autofix_trigger_sample.py 0.0% 10
src/trend_analysis/_autofix_violation_case2.py 0.0% 15
src/trend_analysis/_autofix_violation_case3.py 0.0% 13
src/trend_analysis/_ci_probe_faults.py 0.0% 18
src/trend_analysis/automation_multifailure.py 0.0% 4
src/trend_analysis/constants.py 0.0% 1
src/trend_analysis/selector.py 0.0% 12
src/trend_analysis/weighting.py 0.0% 11
src/trend_analysis/__init__.py 100.0% 0

Low Coverage Files (<50.0%)

File Coverage Missing
src/trend_analysis/_autofix_trigger_sample.py 0.0% 10
src/trend_analysis/_autofix_violation_case2.py 0.0% 15
src/trend_analysis/_autofix_violation_case3.py 0.0% 13
src/trend_analysis/_ci_probe_faults.py 0.0% 18
src/trend_analysis/automation_multifailure.py 0.0% 4
src/trend_analysis/constants.py 0.0% 1
src/trend_analysis/selector.py 0.0% 12
src/trend_analysis/weighting.py 0.0% 11

Updated automatically; will refresh on subsequent CI/Docker completions.


Keepalive checklist

Scope

No scope information available

Tasks

  • No tasks defined

Acceptance criteria

  • No acceptance criteria defined

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 30, 2025

🤖 Keepalive Loop Status

PR #319 | Agent: Codex | Iteration 0/5

Current State

Metric Value
Iteration progress [----------] 0/5
Action wait (missing-agent-label)
Gate success
Tasks 0/0 complete
Keepalive ❌ disabled
Autofix ❌ disabled

🔍 Failure Classification

| Error type | infrastructure |
| Error category | resource |
| Suggested recovery | Confirm the referenced resource exists (repo, PR, branch, workflow, or file). |

The comment claimed "Simple format always has substantive content" but
the code correctly checks for it. Updated comment to accurately reflect
that we verify content rather than assume it exists.

Co-authored-by: stranske <23046322+stranske@users.noreply.github.com>
Copilot AI requested a review from stranske as a code owner December 30, 2025 15:52
Copilot AI changed the title [WIP] Update to prevent contentless follow-up issues Fix misleading comment in formatSimpleFollowUpIssue Dec 30, 2025
@stranske stranske merged commit b7e32b0 into main Dec 30, 2025
72 checks passed
@stranske stranske deleted the copilot/sub-pr-316-another-one branch December 30, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants