Repository navigation
fix(health): restore Health 68 execution and assert durable-tracker liveness #3189
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # Workflows monitored by Health 71 durable-tracker liveness assertions. | ||
| # Each entry must match a row in docs/ops/DURABLE_TRACKING_ISSUES.md. | ||
| trackers: | ||
| - workflow: agents-weekly-metrics.yml | ||
| issue: 2211 | ||
| max_age_hours: 192 | ||
| - workflow: maint-82-sync-dependency-campaign.yml | ||
| issue: 1836 | ||
| max_age_hours: 1 | ||
| - workflow: health-83-dependency-sync-efficiency.yml | ||
| issue: 2897 | ||
| max_age_hours: 192 | ||
| - workflow: health-68-consumer-sync-drift.yml | ||
| issue: 2210 | ||
| max_age_hours: 48 | ||
| - workflow: maint-69-sync-integration-repo.yml | ||
| issue: 2470 | ||
| max_age_hours: 168 | ||
|
There was a problem hiding this comment.
Useful? React with 👍 / 👎. |
||
| - workflow: maint-80-langsmith-metrics-dashboard.yml | ||
| issue: 2415 | ||
| max_age_hours: 192 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,175 @@ | ||
| #!/usr/bin/env python3 | ||
| """Assert durable tracker source workflows executed inside their cadence.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import argparse | ||
| import json | ||
| import os | ||
| import subprocess | ||
| import sys | ||
| from datetime import UTC, datetime | ||
| from pathlib import Path | ||
| from typing import Any | ||
|
|
||
| import yaml | ||
|
|
||
| REPO_ROOT = Path(__file__).resolve().parents[1] | ||
| CONFIG_PATH = REPO_ROOT / "config" / "durable_tracker_liveness.yml" | ||
| TRACKER_DOC = REPO_ROOT / "docs" / "ops" / "DURABLE_TRACKING_ISSUES.md" | ||
| EXECUTABLE_CONCLUSIONS = frozenset({"success", "failure", "cancelled", "timed_out"}) | ||
|
|
||
|
|
||
| def _github_token() -> str: | ||
| token = os.environ.get("GH_TOKEN") or os.environ.get("GITHUB_TOKEN") | ||
| if token: | ||
| return token | ||
| return subprocess.check_output(["gh", "auth", "token"], text=True).strip() | ||
|
|
||
|
|
||
| def _load_config() -> list[dict[str, Any]]: | ||
| data = yaml.safe_load(CONFIG_PATH.read_text(encoding="utf-8")) | ||
| trackers = data.get("trackers") | ||
| if not isinstance(trackers, list) or not trackers: | ||
| raise ValueError(f"{CONFIG_PATH} must define a non-empty trackers list") | ||
| return trackers | ||
|
|
||
|
|
||
| def tracker_doc_workflows() -> set[str]: | ||
| import re | ||
|
|
||
| text = TRACKER_DOC.read_text(encoding="utf-8") | ||
| section_match = re.search( | ||
| r"## Current durable trackers\n\n\| Issue.*?\n\|[-| ]+\n(.*?)(?:\n\n|\n### )", | ||
| text, | ||
| re.DOTALL, | ||
| ) | ||
| assert section_match, "DURABLE_TRACKING_ISSUES.md is missing the tracker table" | ||
| table_body = section_match.group(1) | ||
| workflows = re.findall(r"\[`[^`]+`\]\([^)]*/([^/)]+)\)", table_body) | ||
| return {name for name in workflows if name.endswith(".yml")} | ||
|
|
||
|
|
||
| def _latest_executable_run(repo: str, workflow_file: str, token: str) -> dict[str, Any] | None: | ||
| raw = subprocess.check_output( | ||
| [ | ||
| "gh", | ||
| "api", | ||
| f"repos/{repo}/actions/workflows/{workflow_file}/runs", | ||
| "-f", | ||
| "per_page=100", | ||
|
Comment on lines
+61
to
+62
There was a problem hiding this comment.
In Health 71's new tracker check, passing Useful? React with 👍 / 👎.
Owner
Author
There was a problem hiding this comment. Verified on exact head 251c6bb: |
||
| "--jq", | ||
| ".workflow_runs", | ||
| ], | ||
| text=True, | ||
| env={**os.environ, "GH_TOKEN": token}, | ||
| ) | ||
|
coderabbitai[bot] marked this conversation as resolved.
Resolved
|
||
| runs = json.loads(raw) | ||
| if not isinstance(runs, list): | ||
| return None | ||
| for run in runs: | ||
| if not isinstance(run, dict): | ||
| continue | ||
| conclusion = str(run.get("conclusion") or "") | ||
| if conclusion in EXECUTABLE_CONCLUSIONS: | ||
| return run | ||
| return None | ||
|
|
||
|
|
||
| def _hours_since(iso_timestamp: str) -> float: | ||
| created = datetime.fromisoformat(iso_timestamp.replace("Z", "+00:00")) | ||
| return (datetime.now(UTC) - created).total_seconds() / 3600.0 | ||
|
|
||
|
|
||
| def evaluate_trackers(repo: str, token: str | None = None) -> list[dict[str, Any]]: | ||
| auth = token or _github_token() | ||
| results: list[dict[str, Any]] = [] | ||
| for entry in _load_config(): | ||
| workflow = str(entry["workflow"]) | ||
| issue = int(entry["issue"]) | ||
| max_age_hours = float(entry["max_age_hours"]) | ||
| latest = _latest_executable_run(repo, workflow, auth) | ||
| if latest is None: | ||
| results.append( | ||
| { | ||
| "workflow": workflow, | ||
| "issue": issue, | ||
| "healthy": False, | ||
| "reason": "no executable run found (only action_required/skipped)", | ||
| } | ||
| ) | ||
| continue | ||
| hours = _hours_since(str(latest["created_at"])) | ||
| healthy = hours <= max_age_hours | ||
| results.append( | ||
| { | ||
| "workflow": workflow, | ||
| "issue": issue, | ||
| "healthy": healthy, | ||
| "latest_conclusion": latest.get("conclusion"), | ||
| "latest_created_at": latest.get("created_at"), | ||
| "hours_since": round(hours, 2), | ||
| "max_age_hours": max_age_hours, | ||
| "run_url": latest.get("html_url"), | ||
| } | ||
| ) | ||
| return results | ||
|
|
||
|
|
||
| def _comment_on_tracker(repo: str, issue: int, body: str, token: str) -> None: | ||
| subprocess.run( | ||
| ["gh", "issue", "comment", str(issue), "--repo", repo, "--body", body], | ||
| check=True, | ||
| env={**os.environ, "GH_TOKEN": token}, | ||
| ) | ||
|
|
||
|
|
||
| def main(argv: list[str] | None = None) -> int: | ||
| parser = argparse.ArgumentParser() | ||
| parser.add_argument("--repo", default=os.environ.get("GITHUB_REPOSITORY", "stranske/Workflows")) | ||
| parser.add_argument("--comment-on-failure", action="store_true") | ||
| parser.add_argument("--json", action="store_true") | ||
| args = parser.parse_args(argv) | ||
|
|
||
| configured = {str(entry["workflow"]) for entry in _load_config()} | ||
| documented = tracker_doc_workflows() | ||
| missing_from_config = sorted(documented - configured) | ||
| extra_in_config = sorted(configured - documented) | ||
| if missing_from_config or extra_in_config: | ||
| print( | ||
| "Tracker workflow coverage mismatch: " | ||
| f"missing_from_config={missing_from_config} extra_in_config={extra_in_config}", | ||
| file=sys.stderr, | ||
| ) | ||
| return 2 | ||
|
|
||
| token = _github_token() | ||
| results = evaluate_trackers(args.repo, token) | ||
| unhealthy = [item for item in results if not item.get("healthy")] | ||
|
|
||
| if args.json: | ||
| print(json.dumps({"results": results, "unhealthy_count": len(unhealthy)}, indent=2)) | ||
| else: | ||
| for item in results: | ||
| status = "healthy" if item.get("healthy") else "UNHEALTHY" | ||
| print(f"{item['workflow']}\t{status}\t{item}") | ||
|
|
||
| if args.comment_on_failure and unhealthy: | ||
| for item in unhealthy: | ||
| body = ( | ||
| "## Durable tracker liveness alert\n\n" | ||
| f"Source workflow `{item['workflow']}` has no executable run inside its " | ||
| f"{item.get('max_age_hours', '?')}h cadence.\n\n" | ||
| f"- Latest executable run: {item.get('latest_created_at', 'none')}\n" | ||
| f"- Conclusion: {item.get('latest_conclusion', 'n/a')}\n" | ||
| f"- Hours since: {item.get('hours_since', 'n/a')}\n" | ||
| f"- Run URL: {item.get('run_url', 'n/a')}\n\n" | ||
| "Confirm liveness from workflow run history, not tracker comment activity." | ||
| ) | ||
| _comment_on_tracker(args.repo, int(item["issue"]), body, token) | ||
|
|
||
| return 1 if unhealthy else 0 | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| raise SystemExit(main()) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For every qualifying
workflow_runevent, Bash parses this command before invokingghand fails withunexpected EOF while looking for matching \'`because the jq expression ends withempty']'. Consequently the new debounce step fails, the comparison never runs, and this trigger cannot perform the drift check; keep the closing]` inside the quoted jq expression.Useful? React with 👍 / 👎.