Skip to content

fix(sync): trust base seal contract and visible issue body - #3061

Merged
stranske merged 2 commits into
mainfrom
codex/sync-review-source-fixes
Aug 13, 2026
Merged

fix(sync): trust base seal contract and visible issue body#3061
stranske merged 2 commits into
mainfrom
codex/sync-review-source-fixes

Conversation

@stranske

@stranske stranske commented Aug 13, 2026

Copy link
Copy Markdown
Owner

Summary

  • load the stable sync delivery-seal contract from the exact trusted PR base SHA and fail closed instead of evaluating the candidate copy
  • make the standard generated-delivery Gate checkout the trusted base contract
  • exclude well-formed archived Original-Issue provenance from canonical addressability validation while keeping malformed archives visible

This is the source-of-truth correction for active review findings on stranske/Portable-Alpha-Extension-Model#2220 and stranske/Trend_Model_Project#5819. Maint 68 must refresh the stable candidate/delivery PRs after this merges; the current reviewed heads remain unmergeable.

Validation

  • node --test .github/scripts/__tests__/path-classifier.test.js — 15 passed
  • python -m pytest tests/scripts/test_issue_format.py -q — 136 passed
  • python -m pytest tests/scripts/test_issue_formatter.py tests/scripts/test_issue_optimizer.py tests/scripts/test_issue_pr_context.py -q — 112 passed
  • python -m pytest tests/workflows/test_agents_issue_optimizer_format_trigger.py tests/workflows/test_sync_manifest_delivery.py tests/scripts/test_validate_template_completeness.py tests/scripts/test_validate_template_sync.py -q — 62 passed
  • python scripts/validate_template_completeness.py — passed
  • python scripts/validate_template_sync.py — passed
  • root/template copies of classify.js and issue_format.py are byte-identical

Review findings addressed

@cursor

cursor Bot commented Aug 13, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 15 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 6e759ab9-450b-45f3-9179-b24b5250715f

📥 Commits

Reviewing files that changed from the base of the PR and between 66e9de1 and abc3664.

📒 Files selected for processing (10)
  • .github/actions/path-classifier/classify.js
  • .github/scripts/__tests__/path-classifier.test.js
  • .github/scripts/issue_format.py
  • .github/workflows/pr-00-gate.yml
  • docs/ops/CONSUMER_REPO_MAINTENANCE.md
  • templates/consumer-repo/.github/actions/path-classifier/classify.js
  • templates/consumer-repo/.github/scripts/issue_format.py
  • templates/consumer-repo/.github/workflows/pr-00-gate.yml
  • templates/consumer-repo/docs/AGENT_ISSUE_FORMAT.md
  • tests/scripts/test_issue_format.py

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0fc125bde0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/scripts/issue_format.py Outdated
@stranske

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: abc3664fc7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@stranske
stranske temporarily deployed to agent-high-privilege August 13, 2026 03:55 — with GitHub Actions Inactive
@stranske-keepalive

Copy link
Copy Markdown
Contributor

Automated Status Summary

Head SHA: 84b999c
Latest Runs: ⏳ pending — Gate
Required contexts: summary
Required: core tests (3.12): ⏳ pending, core tests (3.13): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job Result Logs
(no jobs reported) ⏳ pending

Coverage Overview

  • Coverage history entries: 1

Coverage Trend

Metric Value
Current 76.26%
Baseline 85.00%
Delta -8.74%
Minimum 70.00%
Status ✅ Pass

Top Coverage Hotspots (lowest coverage)

File Coverage Missing
scripts/issue_dedup_smoke.py 0.0% 4
scripts/runner_lib/__main__.py 0.0% 3
scripts/validate_template_sync.py 0.0% 81
scripts/langchain/topic_splitter.py 19.1% 57
tools/codex_log_analyzer.py 19.6% 140
scripts/repo_review_round2_runner.py 25.1% 344
scripts/prune_agent_stubs.py 39.7% 26
scripts/repo_review_round1_runner.py 40.7% 133
tools/ensure_workflow_timeout_variables.py 42.1% 74
scripts/sync_label_docs.py 42.9% 64
tools/discover_model_catalog.py 44.8% 55
scripts/repo_review_backlog_scan.py 45.3% 116
scripts/repo_review_body_writer.py 46.5% 86
tools/codex_session_analyzer.py 47.9% 59
scripts/create_verifier_labels.py 48.3% 58

Low Coverage Files (<50.0%)

File Coverage Missing
scripts/issue_dedup_smoke.py 0.0% 4
scripts/runner_lib/__main__.py 0.0% 3
scripts/validate_template_sync.py 0.0% 81
scripts/langchain/topic_splitter.py 19.1% 57
tools/codex_log_analyzer.py 19.6% 140
scripts/repo_review_round2_runner.py 25.1% 344
scripts/prune_agent_stubs.py 39.7% 26
scripts/repo_review_round1_runner.py 40.7% 133
tools/ensure_workflow_timeout_variables.py 42.1% 74
scripts/sync_label_docs.py 42.9% 64
tools/discover_model_catalog.py 44.8% 55
scripts/repo_review_backlog_scan.py 45.3% 116
scripts/repo_review_body_writer.py 46.5% 86
tools/codex_session_analyzer.py 47.9% 59
scripts/create_verifier_labels.py 48.3% 58

Updated automatically; will refresh on subsequent CI/Docker completions.


Keepalive checklist

Scope

No scope information available

Tasks

  • No tasks defined

Acceptance criteria

  • No acceptance criteria defined

@stranske
stranske merged commit f2e01a6 into main Aug 13, 2026
75 checks passed
@stranske
stranske deleted the codex/sync-review-source-fixes branch August 13, 2026 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants