fix(sync): close delivery review regressions

[stranske]

Summary

• make the exact-synced path classifier fail closed for unsealed stable candidate and delivery PR heads, including repos with custom Gate workflows
• recognize plural Create files ... issue instructions
• exclude archived Original Issue provenance from final formatted-issue validation
• document the custom-Gate delivery-seal contract and keep template copies exact

Live-fleet evidence

The first stable-delivery promotion exposed these three shared-source findings on Portable-Alpha-Extension-Model#2220 and Trend_Model_Project#5819. The existing stable delivery PRs remain open and unmerged. After this source fix is reviewed, the no-filter canary/evidence/promotion cycle will update those same PRs in place.

Validation

• node --test .github/scripts/__tests__/*.test.js — 1,350 passed, 1 skipped
• uv run pytest -q — 4,719 passed, 12 skipped, 3 expected failures
• focused post-rebase JavaScript contract tests — 13 passed
• focused post-rebase Python tests — 207 passed
• uv run ruff check ... — passed
• uv run black --check --fast ... — passed
• uv run python scripts/validate_template_sync.py — passed
• git diff --check origin/main...HEAD — passed

Summary by CodeRabbit

• Bug Fixes

  • Improved validation for synchronized pull requests by rejecting unsealed, expired, fork-originated, or otherwise invalid deliveries.
  • Recognized both “Create file” and “Create files” wording when identifying newly created paths.
  • Prevented archived “Original Issue” content from affecting formatted issue validation.

• Documentation

  • Added guidance for custom workflows to enforce synchronized delivery validation.

• Tests

  • Added coverage for delivery validation, plural file creation wording, and archived issue content handling.

[cursor]

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0b4735e3-9b22-4f05-bd6f-1bf9b1ebe216

📥 Commits

Reviewing files that changed from the base of the PR and between 633d14a and 6aa44c3.

📒 Files selected for processing (10)

• .github/actions/path-classifier/classify.js
• .github/scripts/__tests__/path-classifier.test.js
• .github/scripts/issue_format.py
• docs/ops/CONSUMER_REPO_MAINTENANCE.md
• scripts/langchain/issue_formatter.py
• templates/consumer-repo/.github/actions/path-classifier/classify.js
• templates/consumer-repo/.github/scripts/issue_format.py
• templates/consumer-repo/scripts/langchain/issue_formatter.py
• tests/scripts/test_issue_format.py
• tests/scripts/test_issue_formatter.py

---

📝 Walkthrough

Walkthrough

The path classifier now validates stable sync pull requests against delivery seals before classification. Issue validators now support plural file-creation wording and exclude archived Original Issue blocks from formatted-output validation. Tests and maintenance guidance cover these changes.

Changes

Stable delivery validation

Layer / File(s)	Summary
Stable delivery validation flow .github/actions/path-classifier/classify.js, templates/consumer-repo/.github/actions/path-classifier/classify.js	Stable sync branches now require same-repository origin and a valid delivery contract with an unexpired exact-head seal. Invalid required deliveries cause main to throw before classification.
Delivery validation coverage and guidance .github/scripts/__tests__/path-classifier.test.js, docs/ops/CONSUMER_REPO_MAINTENANCE.md	Tests cover unsealed, valid, expired, exact-head, and fork-originated deliveries. Maintenance guidance requires equivalent validation for custom Gates.

Issue validation updates

Layer / File(s)	Summary
Plural file creation validation .github/scripts/issue_format.py, templates/consumer-repo/.github/scripts/issue_format.py, tests/scripts/test_issue_format.py	Creation phrases now accept both singular and plural file/files wording. Tests verify that all listed paths are recognized as new.
Visible formatted-output validation scripts/langchain/issue_formatter.py, templates/consumer-repo/scripts/langchain/issue_formatter.py, tests/scripts/test_issue_formatter.py	Embedded Original Issue content is removed before canonical and fallback validation. Tests verify that only visible formatted content reaches the validator.

Estimated code review effort: 4 (Complex) | ~45 minutes

Possibly related PRs

• stranske/Workflows#3049: Introduces the stable delivery-seal and lease-contract mechanisms extended by this change.
• stranske/Workflows#2901: Concerns sync delivery lease contracts and validation of current, unexpired delivery records.
• stranske/Workflows#3036: Modifies the same issue-format validators and regression-test paths.

Suggested labels: verify:compare

Suggested reviewers: codex-automation

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: fixing delivery review regressions in synchronization workflows.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/sync-delivery-followup

---

_{Comment @coderabbitai help to get the list of available commands.}

[agents-workflows-bot]

Automated Status Summary

Head SHA: 61ade7f
Latest Runs: ⏳ pending — Gate
Required contexts: summary
Required: core tests (3.12): ⏳ pending, core tests (3.13): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job	Result	Logs
(no jobs reported)	⏳ pending	—

Coverage Overview

• Coverage history entries: 0

Updated automatically; will refresh on subsequent CI/Docker completions.

---

Keepalive checklist

Scope

No scope information available

Tasks

• No tasks defined

Acceptance criteria

• No acceptance criteria defined