fix(agents): skip closed issue bridge events - #2982
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe issue intake workflows now reject closed issues before processing agent labels. A regression test checks both workflow variants. The template drift baseline and worker metadata were updated. ChangesIssue intake guard
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Workflow source neededPR #2982 needs either a linked GitHub issue or one valid non-issue Workflow Source before PR metadata automation can manage it safely. Please do one of:
Once a valid source is present, this warning will not be reposted. |
Automated Status SummaryHead SHA: 6b1b9ba
Coverage Overview
Coverage Trend
Top Coverage Hotspots (lowest coverage)
Low Coverage Files (<50.0%)
Updated automatically; will refresh on subsequent CI/Docker completions. Keepalive checklistScopeNo scope information available Tasks
Acceptance criteria
|
There was a problem hiding this comment.
Pull request overview
Prevents closed-issue label events (agent:* / agents:*) from triggering the issue intake bridge, avoiding duplicate bootstrap PR creation. The guard is applied in both the Workflows source intake workflow and the consumer template, with regression coverage and an updated intentional template-drift baseline.
Changes:
- Add a
github.event.issue.state != 'closed'gate to the intake job conditions so closed-issue label events do not start the bridge. - Add a regression test asserting both the source and template workflows contain the closed-issue guard.
- Re-baseline the intentional drift fingerprints for the intake workflow/template pair.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/workflows/test_issue_bridge_triggers.py | Adds regression coverage to ensure both intake surfaces include the closed-issue guard. |
| templates/consumer-repo/.github/workflows/agents-issue-intake.yml | Gates bridge execution on issues being non-closed before evaluating agent label presence. |
| config/template-drift-allowlist.txt | Updates the allowlist fingerprints/reason for the intentional intake workflow drift baseline. |
| .github/workflows/agents-63-issue-intake.yml | Adds a closed-issue guard to the intake condition while preserving unlabeled handling and label checks. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…e cover Co-authored-by: Cursor <cursoragent@cursor.com>
Closer recovery — Gate
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/workflows/test_issue_bridge_triggers.py`:
- Around line 154-160: Update the workflow assertions in the test covering
source and template so each workflow is parsed and the `if` conditions for
`jobs.normalize_inputs` and `jobs.check_labels` explicitly contain
`github.event.issue.state != 'closed'`. Retain the existing literal text
assertion as an additional gate requirement, but do not rely on raw workflow
text to validate these job conditions.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 53eb89b9-5f64-4194-8091-26a6f58a203c
📒 Files selected for processing (5)
.github/workflows/agents-63-issue-intake.ymlconfig/template-drift-allowlist.txtlangsmith-fleet-worker-attempt.jsontemplates/consumer-repo/.github/workflows/agents-issue-intake.ymltests/workflows/test_issue_bridge_triggers.py
Parse source/template intake workflows and require the closed-state guard in normalize_inputs/check_labels if conditions, keeping the literal gate assertion CodeRabbit asked to strengthen. Co-authored-by: Cursor <cursoragent@cursor.com>
Closer review disposition (83d092c)Addressed the active CodeRabbit thread on
Validation: Next: post-push ≥7m window from exact head |
Closer verifier disposition — skipped (no acceptance criteria)Agents Verifier run Skip reason (durable): Evidence:
Closer treats this as terminal verifier disposition for #2982 (skip ≠ pending). |
Prevents
agents:*status-label events on closed issues from starting the intake bridge and creating duplicate bootstrap PRs. Applies the guard in the Workflows source and consumer template, with regression coverage and refreshed intentional template-drift baseline.Summary by CodeRabbit
Bug Fixes
Tests
Chores