fix(gate): preserve issue format guard setup failures - #2976
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe issue-format validator accepts section aliases with parenthesized, hyphen, or slash qualifiers. Regression tests cover the new qualifiers. Guard workflows use strict shell handling during setup and controlled return-code handling during validator execution. Worker metadata records PR 2976. ChangesIssue format validation
Worker metadata
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/scripts/test_issue_format.py`:
- Around line 54-64: Update
test_heading_with_spaced_trailing_qualifier_matches_required_section and its
validator setup so the test executes both .github/scripts/issue_format.py and
templates/consumer-repo/.github/scripts/issue_format.py, either by
parameterizing the validator path or adding a synchronization test. Preserve the
existing assertions for both validator copies and ensure the changed _find
behavior is covered in each.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 8a53bcf3-4258-4a92-b763-ced17bca891b
📒 Files selected for processing (5)
.github/scripts/issue_format.py.github/workflows/agents-issue-format-guard.ymltemplates/consumer-repo/.github/scripts/issue_format.pytemplates/consumer-repo/.github/workflows/agents-issue-format-guard.ymltests/scripts/test_issue_format.py
There was a problem hiding this comment.
Pull request overview
This PR updates the issue-format guard workflow and its validator to (1) fail fast on setup errors while still capturing only the validator’s exit status, and (2) recognize documented heading qualifiers that use spaced - or / separators. The changes are applied source-first and mirrored into the consumer template surfaces.
Changes:
- Update the issue-format guard workflow to use
set -euo pipefailfor setup, while temporarily disabling-eonly around the validator invocation to capture its exit code. - Extend the issue-format validator heading matching to accept
"<alias> - …"and"<alias> / …"in addition to the existing"<alias> (…"form. - Add regression tests covering spaced trailing qualifiers for both
-and/.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/scripts/test_issue_format.py | Adds coverage for spaced trailing qualifier headings (- and /). |
| .github/workflows/agents-issue-format-guard.yml | Preserves fail-fast setup while capturing validator exit status reliably. |
| .github/scripts/issue_format.py | Accepts additional trailing qualifier forms in heading detection. |
| templates/consumer-repo/.github/workflows/agents-issue-format-guard.yml | Mirrors the workflow guard changes for consumer template sync. |
| templates/consumer-repo/.github/scripts/issue_format.py | Mirrors the validator heading-matching update for consumers. |
Co-authored-by: Cursor <cursoragent@cursor.com>
|
Runner dispatch state for autofix on PR #2976. Do not edit. |
🤖 Keepalive Loop StatusPR #2976 | Agent: Codex | Iteration 0/12 Current State
Last Codex Run
To retry immediately:
Or wait for the next successful Gate run to automatically retry. 🔍 Failure Classification| Error type | infrastructure |
|
Keepalive Work Log (click to expand)
|
|
Runner dispatch state for codex on PR #2976. Do not edit. |
Provider Comparison ReportProvider Summary
📋 Full Provider Details (click to expand)openai
anthropic
Agreement
DisagreementNo major disagreements detected. Unique Insights
🔍 LangSmith Traces |
Source-first correction for active consumer sync PR review debt.
Validation:
python -m pytest -q tests/scripts/test_issue_format.py(17 passed)python scripts/sync_tool_versions.py --checkpython scripts/validate_template_sync.pygit diff --checkSummary by CodeRabbit
Bug Fixes
Tests