fix(sync): clarify generated validation contracts - #2914
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 32 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
Comment |
dc9d310 to
9630543
Compare
There was a problem hiding this comment.
Pull request overview
This PR tightens generated validation and runtime-pin clarity by (a) making approval-stage policy validation errors point to the correct config key path, and (b) renaming the PyYAML runtime pin constant so its meaning matches what it actually controls.
Changes:
- Clarify approval-stage per-category override validation errors by including the
approval_stage.key path. - Rename the PyYAML pin constant in
check_deliberate_breakfrom a pytest-misleading name toPYYAML_VERSION, and update the related unit test accordingly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tools/evaluate_model_benchmark.py | Updates approval-stage override validation error strings to be more actionable/config-path-specific. |
| scripts/check_deliberate_break.py | Renames the PyYAML version pin constant and uses it consistently when deciding whether to install the locked dependency. |
| tests/scripts/test_check_deliberate_break.py | Updates the test to reference the renamed PyYAML pin constant. |
Automated Status SummaryHead SHA: 8960117
Coverage Overview
Coverage Trend
Top Coverage Hotspots (lowest coverage)
Low Coverage Files (<50.0%)
Updated automatically; will refresh on subsequent CI/Docker completions. Keepalive checklistScopeNo scope information available Tasks
Acceptance criteria
|
Summary
Validation
Follow-up to the corrected consumer wave generated from #2911.