Skip to content

fix(sync): clarify generated validation contracts - #2914

Merged
stranske merged 2 commits into
mainfrom
codex/sync-review-cleanup-20260803
Aug 4, 2026
Merged

fix(sync): clarify generated validation contracts#2914
stranske merged 2 commits into
mainfrom
codex/sync-review-cleanup-20260803

Conversation

@stranske

@stranske stranske commented Aug 4, 2026

Copy link
Copy Markdown
Owner

Summary

  • name the PyYAML runtime pin for the package it controls
  • include the approval-stage config path in category-floor validation errors
  • preserve the existing generated behavior while resolving the live consumer review findings

Validation

  • 67 focused tests passed
  • Black check passed
  • Ruff check passed
  • git diff --check passed

Follow-up to the corrected consumer wave generated from #2911.

Copilot AI review requested due to automatic review settings August 4, 2026 03:14
@cursor

cursor Bot commented Aug 4, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 32 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 6ede59db-bb80-478d-a500-e4b3d39e9549

📥 Commits

Reviewing files that changed from the base of the PR and between 5874c5e and 9630543.

📒 Files selected for processing (4)
  • scripts/check_deliberate_break.py
  • tests/scripts/test_check_deliberate_break.py
  • tests/workflows/test_sync_manifest_delivery.py
  • tools/evaluate_model_benchmark.py

Comment @coderabbitai help to get the list of available commands.

@stranske
stranske force-pushed the codex/sync-review-cleanup-20260803 branch from dc9d310 to 9630543 Compare August 4, 2026 03:16
@stranske
stranske enabled auto-merge August 4, 2026 03:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens generated validation and runtime-pin clarity by (a) making approval-stage policy validation errors point to the correct config key path, and (b) renaming the PyYAML runtime pin constant so its meaning matches what it actually controls.

Changes:

  • Clarify approval-stage per-category override validation errors by including the approval_stage. key path.
  • Rename the PyYAML pin constant in check_deliberate_break from a pytest-misleading name to PYYAML_VERSION, and update the related unit test accordingly.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
tools/evaluate_model_benchmark.py Updates approval-stage override validation error strings to be more actionable/config-path-specific.
scripts/check_deliberate_break.py Renames the PyYAML version pin constant and uses it consistently when deciding whether to install the locked dependency.
tests/scripts/test_check_deliberate_break.py Updates the test to reference the renamed PyYAML pin constant.

Comment thread tools/evaluate_model_benchmark.py
Comment thread scripts/check_deliberate_break.py
@agents-workflows-bot

agents-workflows-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Automated Status Summary

Head SHA: 8960117
Latest Runs: ⏳ pending — Gate
Required contexts: summary
Required: core tests (3.12): ⏳ pending, core tests (3.13): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job Result Logs
(no jobs reported) ⏳ pending

Coverage Overview

  • Coverage history entries: 1

Coverage Trend

Metric Value
Current 76.08%
Baseline 85.00%
Delta -8.92%
Minimum 70.00%
Status ✅ Pass

Top Coverage Hotspots (lowest coverage)

File Coverage Missing
scripts/issue_dedup_smoke.py 0.0% 4
scripts/runner_lib/__main__.py 0.0% 3
scripts/validate_template_sync.py 0.0% 81
scripts/langchain/topic_splitter.py 19.1% 57
tools/codex_log_analyzer.py 19.6% 140
scripts/repo_review_round2_runner.py 25.1% 344
scripts/prune_agent_stubs.py 39.7% 26
scripts/repo_review_round1_runner.py 40.7% 133
tools/ensure_workflow_timeout_variables.py 42.1% 74
scripts/sync_label_docs.py 42.9% 64
tools/discover_model_catalog.py 44.8% 55
scripts/repo_review_backlog_scan.py 45.3% 116
scripts/repo_review_body_writer.py 46.5% 86
tools/codex_session_analyzer.py 47.9% 59
scripts/create_verifier_labels.py 48.3% 58

Low Coverage Files (<50.0%)

File Coverage Missing
scripts/issue_dedup_smoke.py 0.0% 4
scripts/runner_lib/__main__.py 0.0% 3
scripts/validate_template_sync.py 0.0% 81
scripts/langchain/topic_splitter.py 19.1% 57
tools/codex_log_analyzer.py 19.6% 140
scripts/repo_review_round2_runner.py 25.1% 344
scripts/prune_agent_stubs.py 39.7% 26
scripts/repo_review_round1_runner.py 40.7% 133
tools/ensure_workflow_timeout_variables.py 42.1% 74
scripts/sync_label_docs.py 42.9% 64
tools/discover_model_catalog.py 44.8% 55
scripts/repo_review_backlog_scan.py 45.3% 116
scripts/repo_review_body_writer.py 46.5% 86
tools/codex_session_analyzer.py 47.9% 59
scripts/create_verifier_labels.py 48.3% 58

Updated automatically; will refresh on subsequent CI/Docker completions.


Keepalive checklist

Scope

No scope information available

Tasks

  • No tasks defined

Acceptance criteria

  • No acceptance criteria defined

@stranske
stranske merged commit 802706a into main Aug 4, 2026
48 checks passed
@stranske
stranske deleted the codex/sync-review-cleanup-20260803 branch August 4, 2026 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants