fix(llm): install provider clients for model pilot - #2767
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 34 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Workflow source neededPR #2767 needs either a linked GitHub issue or one valid non-issue Workflow Source before PR metadata automation can manage it safely. Please do one of:
Once a valid source is present, this warning will not be reposted. |
There was a problem hiding this comment.
Pull request overview
This PR hardens the model-evaluation pilot workflow so it installs the provider client dependencies required by the verifier’s LangChain integration, and adds a failure gate to prevent “green” pilot runs that produce unusable evaluation evidence.
Changes:
- Update the
maint-78pilot workflow to run with bothdevandlangchainextras so provider clients are available. - Add a post-run gate in the pilot runner to fail the run when a candidate produces zero schema-valid rows.
- Extend workflow and tool tests to assert the updated invocation and validate unusable-candidate detection.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/run_model_eval_pilot.py | Adds unusable-candidate detection and fails the runner when evidence is unusable. |
| tests/workflows/test_model_eval_pilot_workflow.py | Verifies the workflow runs the pilot with the langchain extra and still uses module execution. |
| tests/tools/test_run_model_eval_pilot.py | Adds unit coverage for unusable-candidate detection logic. |
| .github/workflows/maint-78-model-evaluation-pilot.yml | Installs langchain extra during pilot execution to ensure provider clients are present. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6842ff14dd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Automated Status SummaryHead SHA: b70dc36
Coverage Overview
Coverage Trend
Top Coverage Hotspots (lowest coverage)
Low Coverage Files (<50.0%)
Updated automatically; will refresh on subsequent CI/Docker completions. Keepalive checklistScopeNo scope information available Tasks
Acceptance criteria
|
Follow-up to #2740, #2766, and pilot run #29221382906.
The repaired pilot reached evaluation but all 180 rows were invalid because the workflow installed only the
devextra; the provider clients are in thelangchainextra. This installs both extras and makes the runner fail if any configured candidate produces zero schema-valid rows, preventing a green run with unusable evidence.Validation:
uv run --extra dev --extra langchain