Skip to content

fix(autofix): prevent clean mode label race condition #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stranske merged 1 commit into from
Dec 29, 2025
Merged

fix(autofix): prevent clean mode label race condition #274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .github/workflows/reusable-18-autofix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ on:
workflow_call:
inputs:
opt_in_label:
description: 'Label to opt-in when PR is draft'
description: 'Label to opt-in when PR is draft (should differ from clean_label)'
required: false
default: 'autofix:clean'
default: 'autofix'
type: string
commit_prefix:
description: 'Commit message prefix'
Expand Down Expand Up @@ -300,6 +300,7 @@ jobs:
env:
PR_NUMBER: ${{ inputs.pr_number }}
OPT_IN_LABEL: ${{ inputs.opt_in_label }}
CLEAN_LABEL: ${{ inputs.clean_label }}
with:
script: |
const prNumber = Number(process.env.PR_NUMBER || '0');
Expand All @@ -308,6 +309,14 @@ jobs:
return;
}
const label = process.env.OPT_IN_LABEL;
const cleanLabel = process.env.CLEAN_LABEL;
// Don't add the clean mode label here - that should only be added by
// the gate workflow when it detects a cosmetic-only failure. Adding it
// unconditionally causes all autofix runs to be in clean mode.
if (label === cleanLabel) {
core.info(`Skipping label application: opt_in_label '${label}' equals clean_label, which should only be added by gate workflow.`);
return;
}
try {
await github.rest.issues.addLabels({
owner: context.repo.owner,
Expand Down
Loading