Skip to content

feat: add agents-verifier to consumer repo sync #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stranske merged 1 commit into from
Dec 26, 2025
Merged

feat: add agents-verifier to consumer repo sync #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/maint-68-sync-consumer-repos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ jobs:
"agents-orchestrator.yml:agents-70-orchestrator.yml"
"agents-pr-meta.yml:agents-pr-meta.yml"
"agents-keepalive-loop.yml:agents-keepalive-loop.yml"
"agents-verifier.yml:agents-verifier.yml"
Copy link

Copilot AI Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new entry is not placed in alphabetical order within the SYNC_FILES array. The array should be sorted alphabetically by filename. Currently the order is:

  • agents-orchestrator.yml
  • agents-orchestrator.yml (duplicate mapping)
  • agents-pr-meta.yml
  • agents-keepalive-loop.yml
  • agents-verifier.yml (new entry)

The correct alphabetical order should be:

  • agents-keepalive-loop.yml
  • agents-orchestrator.yml (both mappings)
  • agents-pr-meta.yml
  • agents-verifier.yml

Move the agents-verifier.yml entry to maintain alphabetical ordering, which improves maintainability and makes it easier to locate entries in the array.

Copilot uses AI. Check for mistakes.
"autofix.yml:autofix.yml"
Comment on lines 113 to 117
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge New verifier never synced to consumers

The verifier thin-caller was added to the sync detection list, but the apply step still only copies orchestrator/pr-meta/keepalive/autofix/pr-00 workflows—there is no agents-verifier.yml entry in SYNC_TEMPLATES, so even when differences are detected the subsequent copy step does nothing and the PR creation stage sees no changes. Consumer repos therefore will not receive or update the verifier workflow despite this addition, defeating the intended sync.

Useful? React with 👍 / 👎.

"pr-00-gate.yml:pr-00-gate.yml"
)
Expand Down
3 changes: 1 addition & 2 deletions templates/consumer-repo/.github/workflows/agents-verifier.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,4 @@ jobs:
with:
# CI workflows to wait for before running verifier
ci_workflows: '["ci.yml", "pr-00-gate.yml"]'
secrets:
CODEX_AUTH_JSON: ${{ secrets.CODEX_AUTH_JSON }}
secrets: inherit
Loading