Skip to content

fix: skip verifier when no acceptance criteria exist #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stranske merged 2 commits into from
Dec 26, 2025
Merged

fix: skip verifier when no acceptance criteria exist #193

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b269f60
fix: skip verifier when no acceptance criteria exist
stranske Dec 26, 2025
fafb1a2
fix: address code review feedback for verifier skip logic
stranske Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .github/scripts/agents_verifier_context.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,9 +206,14 @@ async function buildVerifierContext({ github, context, core }) {

const sections = [];
let acceptanceCount = 0;
let hasAcceptanceContent = false;

const pullSections = parseScopeTasksAcceptanceSections(pull.body || '');
acceptanceCount += countCheckboxes(pullSections.acceptance);
// Check for any acceptance content, not just checkboxes
if (pullSections.acceptance && String(pullSections.acceptance).trim()) {
hasAcceptanceContent = true;
}
const prSections = extractScopeTasksAcceptanceSections(pull.body || '', {
includePlaceholders: true,
});
Expand All @@ -223,6 +228,10 @@ async function buildVerifierContext({ github, context, core }) {
for (const issue of closingIssues) {
const issueSectionsParsed = parseScopeTasksAcceptanceSections(issue.body || '');
acceptanceCount += countCheckboxes(issueSectionsParsed.acceptance);
// Check for any acceptance content, not just checkboxes
if (issueSectionsParsed.acceptance && String(issueSectionsParsed.acceptance).trim()) {
hasAcceptanceContent = true;
}
const issueSections = extractScopeTasksAcceptanceSections(issue.body || '', {
includePlaceholders: true,
});
Expand Down Expand Up @@ -276,6 +285,23 @@ async function buildVerifierContext({ github, context, core }) {
content.push('_No scope, tasks, or acceptance criteria were found in the pull request or linked issues._');
}

// Skip verifier early if there are no acceptance criteria to verify
// Check for any acceptance content (not just checkboxes) to handle plain-text criteria
if (!hasAcceptanceContent) {
const skipReason = 'No acceptance criteria found in PR or linked issues; skipping verifier.';
core?.notice?.(skipReason);
core?.setOutput?.('should_run', 'false');
core?.setOutput?.('skip_reason', skipReason);
core?.setOutput?.('pr_number', String(pull.number || ''));
core?.setOutput?.('issue_numbers', '[]');
core?.setOutput?.('pr_html_url', pull.html_url || '');
core?.setOutput?.('target_sha', targetSha);
core?.setOutput?.('context_path', '');
core?.setOutput?.('acceptance_count', '0');
core?.setOutput?.('ci_results', JSON.stringify(ciResults));
return { shouldRun: false, reason: skipReason, ciResults };
}

const markdown = content.join('\n').trimEnd() + '\n';
const contextPath = path.join(process.cwd(), 'verifier-context.md');
fs.writeFileSync(contextPath, markdown, 'utf8');
Expand Down
Loading