Skip to content

[codex] Prefer latest Codex verifier models - #1899

Merged
stranske merged 1 commit into
mainfrom
codex/verifier-default-latest-model
Apr 26, 2026
Merged

[codex] Prefer latest Codex verifier models#1899
stranske merged 1 commit into
mainfrom
codex/verifier-default-latest-model

Conversation

@stranske

@stranske stranske commented Apr 26, 2026

Copy link
Copy Markdown
Owner

Source: Issue #1836

Related to campaign issue #1836

Automated Status Summary

Scope

Sync/Dependabot Campaign Queue

Remote GitHub Actions owns discovery for sync-generated and Dependabot PR rounds. Local Codex should only claim items from this issue when needs-local-codex work is queued.

Summary

Context for Agent

Related Issues/PRs

Tasks

  • Updated: 2026-04-26T13:55:31.783Z
  • Repos checked: 11/11
  • Open sync PRs: 461
  • Open Dependabot PRs: 0
  • Active review threads queued: 710
  • Items needing local Codex: 0
  • Actionable local Codex items: 0
  • Claimable local Codex items: 0
  • Source-fixed candidates: 0
  • Superseded sync candidates: 120
  • Finished local results without published source changes: 0
  • Claimed local Codex items: 0
  • Next claim lease expires: -

Acceptance criteria

  • Status: local-codex-superseded-sync-candidate
  • Source repo: stranske/Workflows
  • Source sync state: superseded (PR a3e3f6fa23d5 / current ede2607c77be)
    • scripts/aggregate_agent_metrics.py:274 (copilot-pull-request-reviewer): The unsupported-model list is configured via UNSUPPORTED_VERIFIER_MODELS here, but the terminal-disposition coverage ...

Head SHA: c8df7aa
Latest Runs: ❔ in progress — Gate
Required: gate: ❔ in progress

Workflow / Job Result Logs
Agents Auto-Pilot ⏭️ skipped View run
Agents Bot Comment Handler ✅ success View run
Agents Keepalive Loop ⏹️ cancelled View run
Agents Verifier ✅ success View run
Auto-label Dependabot PRs ⏭️ skipped View run
CI Autofix Loop ✅ success View run
Create Issue from Verification (Enhanced) ⏭️ skipped View run
Create New PR from Verification ⏭️ skipped View run
Gate ❔ in progress View run
Health 40 Sweep ✅ success View run
Health 44 Gate Branch Protection ❔ in progress View run
Health 45 Agents Guard ✅ success View run
Health 50 Security Scan ❔ in progress View run
Health 73 Template Completeness ✅ success View run
Maint 52 Validate Workflows ✅ success View run
PR 11 - Minimal invariant CI ✅ success View run
Selftest CI ✅ success View run
Validate Sync Manifest ✅ success View run

@stranske-keepalive

stranske-keepalive Bot commented Apr 26, 2026

Copy link
Copy Markdown
Contributor

Automated Status Summary

Head SHA: 40f11b6
Latest Runs: ⏳ pending — Gate
Required contexts: Gate / gate, Health 45 Agents Guard / guard
Required: core tests (3.12): ⏳ pending, core tests (3.13): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job Result Logs
(no jobs reported) ⏳ pending

Coverage Overview

  • Coverage history entries: 1

Coverage Trend

Metric Value
Current 93.12%
Baseline 85.00%
Delta +8.12%
Minimum 70.00%
Status ✅ Pass

Top Coverage Hotspots (lowest coverage)

File Coverage Missing
src/cli_parser.py 81.8% 4
src/percentile_calculator.py 95.0% 1
src/aggregator.py 95.0% 2
src/__init__.py 100.0% 0
src/ndjson_parser.py 100.0% 0

Updated automatically; will refresh on subsequent CI/Docker completions.


Keepalive checklist

Scope

Sync/Dependabot Campaign Queue

Remote GitHub Actions owns discovery for sync-generated and Dependabot PR rounds. Local Codex should only claim items from this issue when needs-local-codex work is queued.

Summary

Context for Agent

Related Issues/PRs

Tasks

  • Updated: 2026-04-26T13:55:31.783Z
  • Repos checked: 11/11
  • Open sync PRs: 461
  • Open Dependabot PRs: 0
  • Active review threads queued: 710
  • Items needing local Codex: 0
  • Actionable local Codex items: 0
  • Claimable local Codex items: 0
  • Source-fixed candidates: 0
  • Superseded sync candidates: 120
  • Finished local results without published source changes: 0
  • Claimed local Codex items: 0
  • Next claim lease expires: -

Acceptance criteria

  • Status: local-codex-superseded-sync-candidate
  • Source repo: stranske/Workflows
  • Source sync state: superseded (PR a3e3f6fa23d5 / current ede2607c77be)
    • scripts/aggregate_agent_metrics.py:274 (copilot-pull-request-reviewer): The unsupported-model list is configured via UNSUPPORTED_VERIFIER_MODELS here, but the terminal-disposition coverage ...

@stranske-keepalive

stranske-keepalive Bot commented Apr 26, 2026

Copy link
Copy Markdown
Contributor

🤖 Keepalive Loop Status

PR #1899 | Agent: Codex | Iteration 0/5

Current State

Metric Value
Iteration progress [----------] 0/5
Action wait (missing-agent-label)
Disposition skipped (transient)
Gate success
Tasks 0/4 complete
Timeout 45 min (default)
Timeout usage 3m elapsed (7%, 42m remaining)
Keepalive ❌ disabled
Autofix ❌ disabled

🔍 Failure Classification

| Error type | infrastructure |
| Error category | resource |
| Suggested recovery | Confirm the referenced resource exists (repo, PR, branch, workflow, or file). |

@stranske-keepalive

stranske-keepalive Bot commented Apr 26, 2026

Copy link
Copy Markdown
Contributor
Keepalive Work Log (click to expand)
# Time (UTC) Agent Action Result Files Tasks Progress Commit Gate
0 2026-04-26 14:29:41 Codex wait (missing-agent-label-transient) skipped 0 0/4
0 2026-04-26 14:30:14 Codex wait (missing-agent-label-transient) skipped 0 0/4 cancelled
0 2026-04-26 14:32:42 Codex wait (missing-agent-label-transient) skipped 0 0/4 success
0 2026-04-26 14:35:38 Codex wait (missing-agent-label-transient) skipped 0 0/4 success

@stranske
stranske temporarily deployed to agent-high-privilege April 26, 2026 14:29 — with GitHub Actions Inactive
@stranske
stranske marked this pull request as ready for review April 26, 2026 14:32
Copilot AI review requested due to automatic review settings April 26, 2026 14:32
@stranske
stranske merged commit 3abd393 into main Apr 26, 2026
105 of 111 checks passed
@stranske
stranske deleted the codex/verifier-default-latest-model branch April 26, 2026 14:32
@stranske
stranske temporarily deployed to agent-high-privilege April 26, 2026 14:32 — with GitHub Actions Inactive

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Codex-based verifier workflow to prefer newer default models and add runtime fallback behavior, while ensuring terminal-disposition metadata reflects the model actually used.

Changes:

  • Bumped the default Codex verifier model and introduced an ordered fallback list.
  • Added a retry loop in the verifier run step to fall back when a model appears unavailable.
  • Updated terminal-disposition collection/writing to prefer the runtime-selected model outputs, with test updates to match.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/reusable-agents-verifier.yml Switches default model to gpt-5.5, adds fallback candidates + runtime retry loop, and records the selected model/reason for terminal disposition.
tests/workflows/test_verifier_terminal_disposition.py Updates assertions to reflect new default/fallback model env vars and runtime-selected model outputs.

fi

if [ "$attempt" -lt "$model_count" ] &&
grep -Eiq "model.*(not supported|not available|unsupported|unavailable)|not compatible" \

Copilot AI Apr 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fallback detection grep pattern treats any occurrence of "not compatible" as a model-unavailable signal, even when the message isn't about the model (e.g., sandbox/config incompatibility). This can incorrectly trigger model fallback and mask the real failure. Consider tightening the regex to only match model-availability errors that clearly reference the model (e.g., patterns that include both "model" and "not compatible" / "unsupported"), or match Codex CLI’s specific error strings.

Suggested change
grep -Eiq "model.*(not supported|not available|unsupported|unavailable)|not compatible" \
grep -Eiq "(model.*(not supported|not available|unsupported|unavailable|not compatible))|((not supported|not available|unsupported|unavailable|not compatible).*model)" \

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants