Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/scripts/__tests__/bot-comment-auth-coverage.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -667,13 +667,16 @@ test('keeps explicit zero parse errors and reports missing organic evidence as n
});

assert.equal(organic.status, 'no-data');
assert.deepEqual(organic.blockers, []);
assert.deepEqual(organic.blockers, [
'missing-organic-agents-bot-comment-handler-wrapper-pull_request',
]);
assert.equal(report.parse_errors, 0);
assert.equal(report.coverage_status, 'no-data');
assert.equal(report.organic_evidence.status, 'no-data');
assert.equal(
report.enforcement.blockers.some((blocker) => blocker.startsWith('missing-organic-')),
false
assert.ok(
report.enforcement.blockers.includes(
'missing-organic-agents-bot-comment-handler-wrapper-pull_request'
)
);
});

Expand Down
19 changes: 16 additions & 3 deletions .github/scripts/bot_comment_auth_coverage.js
Original file line number Diff line number Diff line change
Expand Up @@ -213,13 +213,16 @@ function summarizeOrganicEvidence(records = [], options = {}) {
const latestByComponentEvent = Object.create(null);

if (records.length === 0) {
const blockers = organicChecksDisabled
? []
: missingOrganicEvidenceBlockers(components, requiredEvents);
return {
schema: 'workflows-bot-comment-auth-organic-evidence/v1',
required_events: requiredEvents,
required_components: components,
expected_mode: expectedMode === 'unknown' ? '' : expectedMode,
event_counts: eventCounts,
blockers: [],
blockers,
status: organicChecksDisabled ? 'pass' : 'no-data',
};
}
Expand Down Expand Up @@ -267,6 +270,12 @@ function summarizeOrganicEvidence(records = [], options = {}) {
};
}

function missingOrganicEvidenceBlockers(components = [], requiredEvents = []) {
return components.flatMap((component) =>
requiredEvents.map((eventName) => `missing-organic-${component}-${eventName}`)
);
}

function componentPolicy(component, options = {}) {
const base = COMPONENT_POLICIES[component] || {
expected_mode: '',
Expand Down Expand Up @@ -373,6 +382,10 @@ function isComponentMissingBlocker(blocker) {
return Object.keys(COMPONENT_POLICIES).some((component) => blocker === `missing-${component}`);
}

function isNoDataBlocker(blocker) {
return isComponentMissingBlocker(blocker) || String(blocker).startsWith('missing-organic-');
}

function summarizeBotCommentAuthCoverage(records = [], options = {}) {
const policy = normalizePolicy(options);
const parseErrors = Number(options.parse_errors ?? options.parseErrors ?? 0);
Expand Down Expand Up @@ -469,8 +482,8 @@ function summarizeBotCommentAuthCoverage(records = [], options = {}) {

let coverageStatus = 'pass';
if (authRecords.length === 0) {
const nonMissingBlockers = blockers.filter((blocker) => !isComponentMissingBlocker(blocker));
coverageStatus = nonMissingBlockers.length > 0 ? 'warning' : 'no-data';
const nonNoDataBlockers = blockers.filter((blocker) => !isNoDataBlocker(blocker));
coverageStatus = nonNoDataBlockers.length > 0 ? 'warning' : 'no-data';
} else if (blockers.length > 0) {
coverageStatus = 'warning';
}
Expand Down
3 changes: 3 additions & 0 deletions .github/sync-manifest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,9 @@ scripts:
description: "Checks coverage guard artifacts - required by maint-coverage-guard.yml"

# Scripts directory - CI helpers used by reusable-10-ci-python.yml
- source: scripts/aggregate_agent_metrics.py
description: "Aggregates downloaded weekly agent metrics - required by agents-weekly-metrics.yml"

- source: scripts/coverage_history_append.py
description: "Appends coverage data to history file - required by reusable CI workflow"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -213,13 +213,16 @@ function summarizeOrganicEvidence(records = [], options = {}) {
const latestByComponentEvent = Object.create(null);

if (records.length === 0) {
const blockers = organicChecksDisabled
? []
: missingOrganicEvidenceBlockers(components, requiredEvents);
return {
schema: 'workflows-bot-comment-auth-organic-evidence/v1',
required_events: requiredEvents,
required_components: components,
expected_mode: expectedMode === 'unknown' ? '' : expectedMode,
event_counts: eventCounts,
blockers: [],
blockers,
status: organicChecksDisabled ? 'pass' : 'no-data',
};
}
Expand Down Expand Up @@ -267,6 +270,12 @@ function summarizeOrganicEvidence(records = [], options = {}) {
};
}

function missingOrganicEvidenceBlockers(components = [], requiredEvents = []) {
return components.flatMap((component) =>
requiredEvents.map((eventName) => `missing-organic-${component}-${eventName}`)
);
}

function componentPolicy(component, options = {}) {
const base = COMPONENT_POLICIES[component] || {
expected_mode: '',
Expand Down Expand Up @@ -373,6 +382,10 @@ function isComponentMissingBlocker(blocker) {
return Object.keys(COMPONENT_POLICIES).some((component) => blocker === `missing-${component}`);
}

function isNoDataBlocker(blocker) {
return isComponentMissingBlocker(blocker) || String(blocker).startsWith('missing-organic-');
}

function summarizeBotCommentAuthCoverage(records = [], options = {}) {
const policy = normalizePolicy(options);
const parseErrors = Number(options.parse_errors ?? options.parseErrors ?? 0);
Expand Down Expand Up @@ -469,8 +482,8 @@ function summarizeBotCommentAuthCoverage(records = [], options = {}) {

let coverageStatus = 'pass';
if (authRecords.length === 0) {
const nonMissingBlockers = blockers.filter((blocker) => !isComponentMissingBlocker(blocker));
coverageStatus = nonMissingBlockers.length > 0 ? 'warning' : 'no-data';
const nonNoDataBlockers = blockers.filter((blocker) => !isNoDataBlocker(blocker));
coverageStatus = nonNoDataBlockers.length > 0 ? 'warning' : 'no-data';
} else if (blockers.length > 0) {
coverageStatus = 'warning';
}
Expand Down
Loading
Loading